Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

etcd-tester: change var success->failed

Browse Source 
Previous success overwrites the later failure.
Make it simpler by changing the variable to 'failed'.
This commit is contained in:
Gyu-Ho Lee 2016-04-22 09:21:42 -07:00
parent 69bc0f76bc
commit 0feb88cee1
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/functional-tester/etcd-tester/tester.go
View File

@ -40,11 +40,10 @@ func (tt *tester) runLoop() {
var ( var (
currentRevision int64 currentRevision int64
success bool failed bool
) )
for j, f := range tt.failures { for j, f := range tt.failures {
caseTotalCounter.WithLabelValues(f.Desc()).Inc() caseTotalCounter.WithLabelValues(f.Desc()).Inc()
tt.status.setCase(j) tt.status.setCase(j)
if err := tt.cluster.WaitHealth(); err != nil { if err := tt.cluster.WaitHealth(); err != nil {
@ -53,6 +52,7 @@ func (tt *tester) runLoop() {
plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err) plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err)
return return
} }
failed = true
break break
} }
plog.Printf("[round#%d case#%d] start failure %s", i, j, f.Desc()) plog.Printf("[round#%d case#%d] start failure %s", i, j, f.Desc())
@ -64,6 +64,7 @@ func (tt *tester) runLoop() {
plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err) plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err)
return return
} }
failed = true
break break
} }
plog.Printf("[round#%d case#%d] injected failure", i, j) plog.Printf("[round#%d case#%d] injected failure", i, j)
@ -75,6 +76,7 @@ func (tt *tester) runLoop() {
plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err) plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err)
return return
} }
failed = true
break break
} }
plog.Printf("[round#%d case#%d] recovered failure", i, j) plog.Printf("[round#%d case#%d] recovered failure", i, j)
@ -117,6 +119,7 @@ func (tt *tester) runLoop() {
plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err) plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err)
return return
} }
failed = true
break break
} }
plog.Printf("[round#%d case#%d] all members are consistent with current revisions [revisions: %v]", i, j, revs) plog.Printf("[round#%d case#%d] all members are consistent with current revisions [revisions: %v]", i, j, revs)
@ -128,6 +131,7 @@ func (tt *tester) runLoop() {
plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err) plog.Printf("[round#%d case#%d] cleanup error: %v", i, j, err)
return return
} }
failed = true
break break
} }
plog.Printf("[round#%d case#%d] all members are consistent with storage hashes", i, j) plog.Printf("[round#%d case#%d] all members are consistent with storage hashes", i, j)
@ -138,10 +142,9 @@ func (tt *tester) runLoop() {
} }
plog.Printf("[round#%d case#%d] succeed!", i, j) plog.Printf("[round#%d case#%d] succeed!", i, j)
success = true
} }
if !success { if failed {
continue continue
} }
revToCompact := max(0, currentRevision-10000) revToCompact := max(0, currentRevision-10000)