Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

clientv3: Check the error return from Write in v3Manager#Status (#11837)

Browse Source 
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
This commit is contained in:
Zhihong Yu 2020-05-04 17:43:08 -07:00 committed by GitHub
parent df1d2ca78e
commit 17ed0c6638
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
clientv3/snapshot/v3_snapshot.go
View File

@ -183,18 +183,26 @@ func (s *v3Manager) Status(dbPath string) (ds Status, err error) {
if b == nil { if b == nil {
return fmt.Errorf("cannot get hash of bucket %s", string(next)) return fmt.Errorf("cannot get hash of bucket %s", string(next))
} }
h.Write(next) if _, err := h.Write(next); err != nil {
return fmt.Errorf("cannot write bucket %s : %v", string(next), err)
}
iskeyb := (string(next) == "key") iskeyb := (string(next) == "key")
b.ForEach(func(k, v []byte) error { if err := b.ForEach(func(k, v []byte) error {
h.Write(k) if _, err := h.Write(k); err != nil {
h.Write(v) return fmt.Errorf("cannot write to bucket %s", err.Error())
}
if _, err := h.Write(v); err != nil {
return fmt.Errorf("cannot write to bucket %s", err.Error())
}
if iskeyb { if iskeyb {
rev := bytesToRev(k) rev := bytesToRev(k)
ds.Revision = rev.main ds.Revision = rev.main
} }
ds.TotalKey++ ds.TotalKey++
return nil return nil
}) }); err != nil {
return fmt.Errorf("cannot write bucket %s : %v", string(next), err)
}
} }
return nil return nil
}); err != nil { }); err != nil {