From 18af48a9dcd5555202dda5b615b32bb68e6478a8 Mon Sep 17 00:00:00 2001 From: fanmin shi Date: Thu, 26 Jan 2017 12:17:34 -0800 Subject: [PATCH] integration: add test case in dial_test to ensure balancer.updateAddrs works properly --- clientv3/integration/dial_test.go | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/clientv3/integration/dial_test.go b/clientv3/integration/dial_test.go index 9d9e6b47f..01e49675c 100644 --- a/clientv3/integration/dial_test.go +++ b/clientv3/integration/dial_test.go @@ -26,7 +26,16 @@ import ( ) // TestDialSetEndpoints ensures SetEndpoints can replace unavailable endpoints with available ones. -func TestDialSetEndpoints(t *testing.T) { +func TestDialSetEndpointsBeforeFail(t *testing.T) { + testDialSetEndpoints(t, true) +} + +func TestDialSetEndpointsAfterFail(t *testing.T) { + testDialSetEndpoints(t, false) +} + +// testDialSetEndpoints ensures SetEndpoints can replace unavailable endpoints with available ones. +func testDialSetEndpoints(t *testing.T, setBefore bool) { defer testutil.AfterTest(t) clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3}) defer clus.Terminate(t) @@ -45,13 +54,16 @@ func TestDialSetEndpoints(t *testing.T) { } defer cli.Close() + if setBefore { + cli.SetEndpoints(eps[toKill%3], eps[(toKill+1)%3]) + } // make a dead node clus.Members[toKill].Stop(t) clus.WaitLeader(t) - // update client with available endpoints - cli.SetEndpoints(eps[(toKill+1)%3]) - + if !setBefore { + cli.SetEndpoints(eps[toKill%3], eps[(toKill+1)%3]) + } ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) if _, err = cli.Get(ctx, "foo", clientv3.WithSerializable()); err != nil { t.Fatal(err)