Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

raft: Ensure that Progress is not nil when a MsgSnapStatus comes in.

Browse Source 
This was causing some issues in cockroach cockroachdb/cockroach#2950
This commit is contained in:
Bram Gruneir 2015-12-03 17:49:46 -05:00
parent 5a4a5998a3
commit 1901a4c718
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
raft/raft.go
View File

@ -552,16 +552,18 @@ func (r *raft) Step(m pb.Message) error {
type stepFunc func(r *raft, m pb.Message) type stepFunc func(r *raft, m pb.Message)
func stepLeader(r *raft, m pb.Message) { func stepLeader(r *raft, m pb.Message) {
pr := r.prs[m.From]
// These message types do not require any progress for m.From.
switch m.Type { switch m.Type {
case pb.MsgBeat: case pb.MsgBeat:
r.bcastHeartbeat() r.bcastHeartbeat()
return
case pb.MsgCheckQuorum: case pb.MsgCheckQuorum:
if !r.checkQuorumActive() { if !r.checkQuorumActive() {
r.logger.Warningf("%x stepped down to follower since quorum is not active", r.id) r.logger.Warningf("%x stepped down to follower since quorum is not active", r.id)
r.becomeFollower(r.Term, None) r.becomeFollower(r.Term, None)
} }
return
case pb.MsgProp: case pb.MsgProp:
if len(m.Entries) == 0 { if len(m.Entries) == 0 {
r.logger.Panicf("%x stepped empty MsgProp", r.id) r.logger.Panicf("%x stepped empty MsgProp", r.id)
@ -582,6 +584,21 @@ func stepLeader(r *raft, m pb.Message) {
} }
r.appendEntry(m.Entries...) r.appendEntry(m.Entries...)
r.bcastAppend() r.bcastAppend()
return
case pb.MsgVote:
r.logger.Infof("%x [logterm: %d, index: %d, vote: %x] rejected vote from %x [logterm: %d, index: %d] at term %d",
r.id, r.raftLog.lastTerm(), r.raftLog.lastIndex(), r.Vote, m.From, m.LogTerm, m.Index, r.Term)
r.send(pb.Message{To: m.From, Type: pb.MsgVoteResp, Reject: true})
return
}
// All other message types require a progress for m.From (pr).
pr, prOk := r.prs[m.From]
if !prOk {
r.logger.Debugf("no progress available for %x", m.From)
return
}
switch m.Type {
case pb.MsgAppResp: case pb.MsgAppResp:
pr.recentActive = true pr.recentActive = true
@ -627,10 +644,6 @@ func stepLeader(r *raft, m pb.Message) {
if pr.Match < r.raftLog.lastIndex() { if pr.Match < r.raftLog.lastIndex() {
r.sendAppend(m.From) r.sendAppend(m.From)
} }
case pb.MsgVote:
r.logger.Infof("%x [logterm: %d, index: %d, vote: %x] rejected vote from %x [logterm: %d, index: %d] at term %d",
r.id, r.raftLog.lastTerm(), r.raftLog.lastIndex(), r.Vote, m.From, m.LogTerm, m.Index, r.Term)
r.send(pb.Message{To: m.From, Type: pb.MsgVoteResp, Reject: true})
case pb.MsgSnapStatus: case pb.MsgSnapStatus:
if pr.State != ProgressStateSnapshot { if pr.State != ProgressStateSnapshot {
return return