mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
fix: apply review suggestion
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
This commit is contained in:
parent
d4fbfb8cfb
commit
191fb306ef
@ -765,6 +765,15 @@ func (cfg *Config) Validate() error {
|
|||||||
return fmt.Errorf("--experimental-compact-hash-check-time must be >0 (set to %v)", cfg.ExperimentalCompactHashCheckTime)
|
return fmt.Errorf("--experimental-compact-hash-check-time must be >0 (set to %v)", cfg.ExperimentalCompactHashCheckTime)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// If `--name` isn't configured, then multiple members may have the same "default" name.
|
||||||
|
// When adding a new member with the "default" name as well, etcd may regards its peerURL
|
||||||
|
// as one additional peerURL of the existing member which has the same "default" name,
|
||||||
|
// because each member can have multiple client or peer URLs.
|
||||||
|
// Please refer to https://github.com/etcd-io/etcd/issues/13757
|
||||||
|
if cfg.Name == DefaultName {
|
||||||
|
cfg.logger.Warn("the server is using default name, which might cause error that failed the startup.")
|
||||||
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -90,10 +90,6 @@ func startEtcdOrProxyV2(args []string) {
|
|||||||
lg.Info("failed to detect default host", zap.Error(dhErr))
|
lg.Info("failed to detect default host", zap.Error(dhErr))
|
||||||
}
|
}
|
||||||
|
|
||||||
if cfg.ec.Name == embed.DefaultName {
|
|
||||||
lg.Warn("the server is using default name, which might cause error that failed the startup.")
|
|
||||||
}
|
|
||||||
|
|
||||||
if cfg.ec.Dir == "" {
|
if cfg.ec.Dir == "" {
|
||||||
cfg.ec.Dir = fmt.Sprintf("%v.etcd", cfg.ec.Name)
|
cfg.ec.Dir = fmt.Sprintf("%v.etcd", cfg.ec.Name)
|
||||||
lg.Warn(
|
lg.Warn(
|
||||||
|
Loading…
x
Reference in New Issue
Block a user