Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

pkg: handle version env variable

Browse Source 
Version flag is meant for displaying version and it's a boolean.
It's for an internal use, and we may not want users to set
it in the environment.

Fixes # 11210
This commit is contained in:
Sahdev P. Zala 2019-10-09 18:22:25 -04:00
parent a6a1fdd457
commit 27535517b1
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
etcdmain/config.go
View File

@ -316,6 +316,13 @@ func (cfg *config) parse(arguments []string) error {
}
func (cfg *config) configFromCmdLine() error {
verKey := "ETCD_VERSION"
if verVal := os.Getenv(verKey); verVal != "" {
// unset to avoid any possible side-effect.
os.Unsetenv(verKey)
plog.Warningf("cannot set special environment variable %s=%s", verKey, verVal)
}
err := flags.SetFlagsFromEnv("ETCD", cfg.cf.flagSet)
if err != nil {
return err