Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools/benchmark/cmd: don't panic with nil values in hashKV function

Browse Source 
hashKV checks nilness of 'eh' and 'es', but doesn't use them. Instead
it panics with 'err' which is definitely nil.

This should be avoided, See:
https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/nilness#nilpanic

This patch renames 'eh' and 'es' to 'err' in order to correct the real
errors to panic.

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
This commit is contained in:
Jes Cok 2024-04-04 21:40:12 +08:00
parent bdbf8a2b6b
commit 27a6dd0ca5
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/benchmark/cmd/put.go
View File

@ -170,14 +170,14 @@ func hashKV(cmd *cobra.Command, clients []*v3.Client) {
host := eps[0]
st := time.Now()
rh, eh := clients[0].HashKV(context.Background(), host, 0)
if eh != nil {
fmt.Fprintf(os.Stderr, "Failed to get the hashkv of endpoint %s (%v)\n", host, eh)
rh, err := clients[0].HashKV(context.Background(), host, 0)
if err != nil {
fmt.Fprintf(os.Stderr, "Failed to get the hashkv of endpoint %s (%v)\n", host, err)
panic(err)
}
rt, es := clients[0].Status(context.Background(), host)
if es != nil {
fmt.Fprintf(os.Stderr, "Failed to get the status of endpoint %s (%v)\n", host, es)
rt, err := clients[0].Status(context.Background(), host)
if err != nil {
fmt.Fprintf(os.Stderr, "Failed to get the status of endpoint %s (%v)\n", host, err)
panic(err)
}