store: always check the error

Ensure that we propogate any errors out of the node.Remove operation
back to the user. There is no reason to assume here.
This commit is contained in:
Brandon Philips 2015-04-13 09:58:07 -07:00
parent 54c4d5005d
commit 2a675c08c2

View File

@ -354,8 +354,10 @@ func (s *store) CompareAndDelete(nodePath string, prevValue string, prevIndex ui
s.WatcherHub.notifyWatchers(e, path, true)
}
// delete a key-value pair, no error should happen
n.Remove(false, false, callback)
err = n.Remove(false, false, callback)
if err != nil {
return nil, err
}
s.WatcherHub.notify(e)
s.Stats.Inc(CompareAndDeleteSuccess)