From 2b7c12fb12d6fe88d17b00eac3e1c25f3d616652 Mon Sep 17 00:00:00 2001 From: Gyuho Lee Date: Mon, 5 Feb 2018 21:21:17 -0800 Subject: [PATCH] raft: reuse "last index" in "appendEntry" No need to call "lastIndex" again. "append" call already returns "lastIndex". Signed-off-by: Gyuho Lee --- raft/raft.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/raft/raft.go b/raft/raft.go index a4d744a44..336a7d3ff 100644 --- a/raft/raft.go +++ b/raft/raft.go @@ -604,8 +604,9 @@ func (r *raft) appendEntry(es ...pb.Entry) { es[i].Term = r.Term es[i].Index = li + 1 + uint64(i) } - r.raftLog.append(es...) - r.getProgress(r.id).maybeUpdate(r.raftLog.lastIndex()) + // use latest "last" index after truncate/append + li = r.raftLog.append(es...) + r.getProgress(r.id).maybeUpdate(li) // Regardless of maybeCommit's return, our caller will call bcastAppend. r.maybeCommit() }