From d3ebecddddbbebe94643aecbff114b97c5ebaafa Mon Sep 17 00:00:00 2001 From: Yicheng Qin Date: Wed, 21 Oct 2015 18:19:33 -0700 Subject: [PATCH] pkg/transport: extend wait timeout for write This helps the test to pass safely in semaphore CI. Based on my manual testing, it may take at most 500ms to return error in semaphore CI, so I set 1s as a safe value. --- pkg/transport/timeout_dialer_test.go | 3 ++- pkg/transport/timeout_listener_test.go | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/transport/timeout_dialer_test.go b/pkg/transport/timeout_dialer_test.go index 12eff0f20..14e95516c 100644 --- a/pkg/transport/timeout_dialer_test.go +++ b/pkg/transport/timeout_dialer_test.go @@ -50,7 +50,8 @@ func TestReadWriteTimeoutDialer(t *testing.T) { select { case <-done: - case <-time.After(d.wtimeoutd * 10): + // It waits 1s more to avoid delay in low-end system. + case <-time.After(d.wtimeoutd*10 + time.Second): t.Fatal("wait timeout") } diff --git a/pkg/transport/timeout_listener_test.go b/pkg/transport/timeout_listener_test.go index 6ee15441f..085a57559 100644 --- a/pkg/transport/timeout_listener_test.go +++ b/pkg/transport/timeout_listener_test.go @@ -76,7 +76,8 @@ func TestWriteReadTimeoutListener(t *testing.T) { select { case <-done: - case <-time.After(wln.wtimeoutd * 10): + // It waits 1s more to avoid delay in low-end system. + case <-time.After(wln.wtimeoutd*10 + time.Second): t.Fatal("wait timeout") }