From fd58cf8975c28e940efd4642fb02de5fca9a0be4 Mon Sep 17 00:00:00 2001 From: Brandon Philips Date: Thu, 8 Aug 2013 14:22:01 -0700 Subject: [PATCH] chore(*test.go): use 127.0.0.1 be polite and don't use public ip for listening during tests --- etcd_long_test.go | 4 ++-- etcd_test.go | 4 ++-- test.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/etcd_long_test.go b/etcd_long_test.go index db603b540..e80643a37 100644 --- a/etcd_long_test.go +++ b/etcd_long_test.go @@ -34,7 +34,7 @@ func TestKillLeader(t *testing.T) { var totalTime time.Duration - leader := "0.0.0.0:7001" + leader := "127.0.0.1:7001" for i := 0; i < 10; i++ { port, _ := strconv.Atoi(strings.Split(leader, ":")[1]) @@ -134,7 +134,7 @@ func BenchmarkEtcdDirectCall(b *testing.B) { b.ResetTimer() for i := 0; i < b.N; i++ { - resp, _ := http.Get("http://0.0.0.0:4001/test/speed") + resp, _ := http.Get("http://127.0.0.1:4001/test/speed") resp.Body.Close() } diff --git a/etcd_test.go b/etcd_test.go index f84050f4f..4d6381fc8 100644 --- a/etcd_test.go +++ b/etcd_test.go @@ -14,7 +14,7 @@ import ( func TestSingleNode(t *testing.T) { procAttr := new(os.ProcAttr) procAttr.Files = []*os.File{nil, os.Stdout, os.Stderr} - args := []string{"etcd", "-f", "-d=/tmp/node1"} + args := []string{"etcd", "-h=127.0.0.1", "-f", "-d=/tmp/node1"} process, err := os.StartProcess("etcd", args, procAttr) if err != nil { @@ -56,7 +56,7 @@ func TestSingleNode(t *testing.T) { func TestSingleNodeRecovery(t *testing.T) { procAttr := new(os.ProcAttr) procAttr.Files = []*os.File{nil, os.Stdout, os.Stderr} - args := []string{"etcd", "-d=/tmp/node1"} + args := []string{"etcd", "-h=127.0.0.1", "-d=/tmp/node1"} process, err := os.StartProcess("etcd", append(args, "-f"), procAttr) if err != nil { diff --git a/test.go b/test.go index a850c691c..14369aff1 100644 --- a/test.go +++ b/test.go @@ -59,10 +59,10 @@ func createCluster(size int, procAttr *os.ProcAttr) ([][]string, []*os.Process, argGroup := make([][]string, size) for i := 0; i < size; i++ { if i == 0 { - argGroup[i] = []string{"etcd", "-d=/tmp/node1"} + argGroup[i] = []string{"etcd", "-h=127.0.0.1", "-d=/tmp/node1"} } else { strI := strconv.Itoa(i + 1) - argGroup[i] = []string{"etcd", "-c=400" + strI, "-s=700" + strI, "-d=/tmp/node" + strI, "-C=127.0.0.1:7001"} + argGroup[i] = []string{"etcd", "-h=127.0.0.1", "-c=400" + strI, "-s=700" + strI, "-d=/tmp/node" + strI, "-C=127.0.0.1:7001"} } }