From 32c83becf59fcedca6f14716372c5780ba24ede8 Mon Sep 17 00:00:00 2001 From: sharathsivakumar Date: Thu, 20 Apr 2023 12:36:40 +0200 Subject: [PATCH] fix review: Updated description of --initial-cluster-state flag Signed-off-by: sharathsivakumar --- server/etcdmain/config.go | 3 +-- server/etcdmain/help.go | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/etcdmain/config.go b/server/etcdmain/config.go index 18adce5f7..0896911fe 100644 --- a/server/etcdmain/config.go +++ b/server/etcdmain/config.go @@ -189,8 +189,7 @@ func newConfig() *config { fs.StringVar(&cfg.ec.DNSClusterServiceName, "discovery-srv-name", cfg.ec.DNSClusterServiceName, "Service name to query when using DNS discovery.") fs.StringVar(&cfg.ec.InitialCluster, "initial-cluster", cfg.ec.InitialCluster, "Initial cluster configuration for bootstrapping.") fs.StringVar(&cfg.ec.InitialClusterToken, "initial-cluster-token", cfg.ec.InitialClusterToken, "Initial cluster token for the etcd cluster during bootstrap.") - fs.Var(cfg.cf.clusterState, "initial-cluster-state", "Initial cluster state ('new' or 'existing').") - + fs.Var(cfg.cf.clusterState, "initial-cluster-state", "Initial cluster state ('new' when bootstrapping a new cluster or 'existing' when adding new members to an existing cluster). After successful initialization (bootstrapping or adding), flag is ignored on restarts.") fs.BoolVar(&cfg.ec.StrictReconfigCheck, "strict-reconfig-check", cfg.ec.StrictReconfigCheck, "Reject reconfiguration requests that would cause quorum loss.") fs.BoolVar(&cfg.ec.PreVote, "pre-vote", cfg.ec.PreVote, "Enable to run an additional Raft election phase.") diff --git a/server/etcdmain/help.go b/server/etcdmain/help.go index a9affdee0..54c945ecc 100644 --- a/server/etcdmain/help.go +++ b/server/etcdmain/help.go @@ -103,7 +103,8 @@ Clustering: --initial-cluster 'default=http://localhost:2380' Initial cluster configuration for bootstrapping. --initial-cluster-state 'new' - Initial cluster state ('new' or 'existing'). + Initial cluster state ('new' when bootstrapping a new cluster or 'existing' when adding new members to an existing cluster). + After successful initialization (bootstrapping or adding), flag is ignored on restarts --initial-cluster-token 'etcd-cluster' Initial cluster token for the etcd cluster during bootstrap. Specifying this can protect you from unintended cross-cluster interaction when running multiple clusters.