From 36f5b713bf4cad4702163ed9476ea83de9059b3d Mon Sep 17 00:00:00 2001 From: Anthony Romano Date: Tue, 14 Feb 2017 16:46:01 -0800 Subject: [PATCH] grpcproxy: don't wait for ctx.Done() to close kv donec Causes a goroutine leak in ActiveConnection.Close() tests. Channel is vestigial since removing ccache; revisit if kv ever needs goroutines. --- proxy/grpcproxy/kv.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/proxy/grpcproxy/kv.go b/proxy/grpcproxy/kv.go index 4db3b066f..65f850ed4 100644 --- a/proxy/grpcproxy/kv.go +++ b/proxy/grpcproxy/kv.go @@ -33,11 +33,7 @@ func NewKvProxy(c *clientv3.Client) (pb.KVServer, <-chan struct{}) { cache: cache.NewCache(cache.DefaultMaxEntries), } donec := make(chan struct{}) - go func() { - defer close(donec) - <-c.Ctx().Done() - kv.cache.Close() - }() + close(donec) return kv, donec }