From 51e4bbfeb08c0624fb9a2185edbd61fe2b1ca9c3 Mon Sep 17 00:00:00 2001 From: Yicheng Qin Date: Tue, 9 Sep 2014 20:46:56 -0700 Subject: [PATCH] http: check err return from http.NewRequest --- etcdserver/etcdhttp/http_test.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/etcdserver/etcdhttp/http_test.go b/etcdserver/etcdhttp/http_test.go index df778e37a..8b2493f9f 100644 --- a/etcdserver/etcdhttp/http_test.go +++ b/etcdserver/etcdhttp/http_test.go @@ -363,7 +363,10 @@ func TestV2MachinesEndpoint(t *testing.T) { defer s.Close() for _, tt := range tests { - req, _ := http.NewRequest(tt.method, s.URL+machinesPrefix, nil) + req, err := http.NewRequest(tt.method, s.URL+machinesPrefix, nil) + if err != nil { + t.Fatal(err) + } resp, err := http.DefaultClient.Do(req) if err != nil { t.Fatal(err) @@ -381,7 +384,10 @@ func TestServeMachines(t *testing.T) { h := Handler{Peers: peers} writer := httptest.NewRecorder() - req, _ := http.NewRequest("GET", "", nil) + req, err := http.NewRequest("GET", "", nil) + if err != nil { + t.Fatal(err) + } h.serveMachines(writer, req) w := "http://localhost:8080, http://localhost:8081, http://localhost:8082" if g := writer.Body.String(); g != w {