diff --git a/server/storage/wal/repair_test.go b/server/storage/wal/repair_test.go index b1fd9d25d..e98b4fa58 100644 --- a/server/storage/wal/repair_test.go +++ b/server/storage/wal/repair_test.go @@ -125,7 +125,7 @@ func TestRepairWriteTearLast(t *testing.T) { } return f.Truncate(offset) } - testRepair(t, makeEnts(50), corruptf, 40) + testRepair(t, makeEnts(50), corruptf, 29) } // TestRepairWriteTearMiddle repairs the WAL when there is write tearing diff --git a/server/storage/wal/wal.go b/server/storage/wal/wal.go index ee9727b0d..d9ef667f2 100644 --- a/server/storage/wal/wal.go +++ b/server/storage/wal/wal.go @@ -26,6 +26,8 @@ import ( "sync" "time" + "github.com/jonboulle/clockwork" + "go.uber.org/zap" "go.etcd.io/etcd/client/pkg/v3/fileutil" @@ -92,12 +94,14 @@ type WAL struct { locks []*fileutil.LockedFile // the locked files the WAL holds (the name is increasing) fp *filePipeline + + clock clockwork.Clock } // Create creates a WAL ready for appending records. The given metadata is // recorded at the head of each WAL file, and can be retrieved with ReadAll // after the file is Open. -func Create(lg *zap.Logger, dirpath string, metadata []byte) (*WAL, error) { +func Create(lg *zap.Logger, dirpath string, metadata []byte, walClock ...clockwork.Clock) (*WAL, error) { if Exist(dirpath) { return nil, os.ErrExist } @@ -158,6 +162,12 @@ func Create(lg *zap.Logger, dirpath string, metadata []byte) (*WAL, error) { dir: dirpath, metadata: metadata, } + if walClock != nil { + w.clock = walClock[0] + } else { + w.clock = clockwork.NewRealClock() + } + w.encoder, err = newFileEncoder(f.File, 0) if err != nil { return nil, err @@ -166,7 +176,7 @@ func Create(lg *zap.Logger, dirpath string, metadata []byte) (*WAL, error) { if err = w.saveCrc(0); err != nil { return nil, err } - if err = w.encoder.encode(&walpb.Record{Type: MetadataType, Data: metadata}); err != nil { + if err = w.encoder.encode(&walpb.Record{Type: MetadataType, Data: metadata, CreatedAt: w.clock.Now().Unix()}); err != nil { return nil, err } if err = w.SaveSnapshot(walpb.Snapshot{}); err != nil { @@ -354,6 +364,7 @@ func openAtIndex(lg *zap.Logger, dirpath string, snap walpb.Snapshot, write bool decoder: NewDecoder(rs...), readClose: closer, locks: ls, + clock: clockwork.NewRealClock(), } if write { @@ -748,7 +759,7 @@ func (w *WAL) cut() error { return err } - if err = w.encoder.encode(&walpb.Record{Type: MetadataType, Data: w.metadata}); err != nil { + if err = w.encoder.encode(&walpb.Record{Type: MetadataType, Data: w.metadata, CreatedAt: w.clock.Now().Unix()}); err != nil { return err } @@ -905,7 +916,7 @@ func (w *WAL) Close() error { func (w *WAL) saveEntry(e *raftpb.Entry) error { // TODO: add MustMarshalTo to reduce one allocation. b := pbutil.MustMarshal(e) - rec := &walpb.Record{Type: EntryType, Data: b} + rec := &walpb.Record{Type: EntryType, Data: b, CreatedAt: w.clock.Now().Unix()} if err := w.encoder.encode(rec); err != nil { return err } @@ -919,7 +930,7 @@ func (w *WAL) saveState(s *raftpb.HardState) error { } w.state = *s b := pbutil.MustMarshal(s) - rec := &walpb.Record{Type: StateType, Data: b} + rec := &walpb.Record{Type: StateType, Data: b, CreatedAt: w.clock.Now().Unix()} return w.encoder.encode(rec) } @@ -971,7 +982,7 @@ func (w *WAL) SaveSnapshot(e walpb.Snapshot) error { w.mu.Lock() defer w.mu.Unlock() - rec := &walpb.Record{Type: SnapshotType, Data: b} + rec := &walpb.Record{Type: SnapshotType, Data: b, CreatedAt: w.clock.Now().Unix()} if err := w.encoder.encode(rec); err != nil { return err } @@ -983,7 +994,7 @@ func (w *WAL) SaveSnapshot(e walpb.Snapshot) error { } func (w *WAL) saveCrc(prevCrc uint32) error { - return w.encoder.encode(&walpb.Record{Type: CrcType, Crc: prevCrc}) + return w.encoder.encode(&walpb.Record{Type: CrcType, Crc: prevCrc, CreatedAt: w.clock.Now().Unix()}) } func (w *WAL) tail() *fileutil.LockedFile { diff --git a/server/storage/wal/wal_test.go b/server/storage/wal/wal_test.go index ed3a8893d..fcdef4c1e 100644 --- a/server/storage/wal/wal_test.go +++ b/server/storage/wal/wal_test.go @@ -29,6 +29,8 @@ import ( "strings" "testing" + "github.com/jonboulle/clockwork" + "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "go.uber.org/zap/zaptest" @@ -49,7 +51,7 @@ var ( func TestNew(t *testing.T) { p := t.TempDir() - w, err := Create(zaptest.NewLogger(t), p, []byte("somedata")) + w, err := Create(zaptest.NewLogger(t), p, []byte("somedata"), clockwork.NewFakeClock()) if err != nil { t.Fatalf("err = %v, want nil", err) } @@ -75,17 +77,18 @@ func TestNew(t *testing.T) { var wb bytes.Buffer e := newEncoder(&wb, 0, 0) - err = e.encode(&walpb.Record{Type: CrcType, Crc: 0}) + err = e.encode(&walpb.Record{Type: CrcType, Crc: 0, CreatedAt: w.clock.Now().Unix()}) if err != nil { t.Fatalf("err = %v, want nil", err) } - err = e.encode(&walpb.Record{Type: MetadataType, Data: []byte("somedata")}) + err = e.encode(&walpb.Record{Type: MetadataType, Data: []byte("somedata"), CreatedAt: w.clock.Now().Unix()}) if err != nil { t.Fatalf("err = %v, want nil", err) } r := &walpb.Record{ - Type: SnapshotType, - Data: pbutil.MustMarshal(&walpb.Snapshot{}), + Type: SnapshotType, + Data: pbutil.MustMarshal(&walpb.Snapshot{}), + CreatedAt: w.clock.Now().Unix(), } if err = e.encode(r); err != nil { t.Fatalf("err = %v, want nil", err)