Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12739 from LeoYang90/optimization_watch_prevkv

Browse Source 
create event do not need prevkv range
This commit is contained in:
Gyuho Lee 2021-03-10 09:48:42 -08:00 committed by GitHub
commit 3ead91ca3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/etcdserver/api/v3rpc/watch.go
View File

@ -391,7 +391,7 @@ func (sws *serverWatchStream) sendLoop() {
sws.mu.RUnlock() sws.mu.RUnlock()
for i := range evs { for i := range evs {
events[i] = &evs[i] events[i] = &evs[i]
if needPrevKV { if needPrevKV && !IsCreateEvent(evs[i]) {
opt := mvcc.RangeOptions{Rev: evs[i].Kv.ModRevision - 1} opt := mvcc.RangeOptions{Rev: evs[i].Kv.ModRevision - 1}
r, err := sws.watchable.Range(context.TODO(), evs[i].Kv.Key, nil, opt) r, err := sws.watchable.Range(context.TODO(), evs[i].Kv.Key, nil, opt)
if err == nil && len(r.KVs) != 0 { if err == nil && len(r.KVs) != 0 {
@ -501,6 +501,10 @@ func (sws *serverWatchStream) sendLoop() {
} }
} }
func IsCreateEvent(e mvccpb.Event) bool {
return e.Type == mvccpb.PUT && e.Kv.CreateRevision == e.Kv.ModRevision
}
func sendFragments( func sendFragments(
wr *pb.WatchResponse, wr *pb.WatchResponse,
maxRequestBytes int, maxRequestBytes int,