Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

e2e: check etcdctl endpoint health is healthy if denied permission to key

Browse Source
This commit is contained in:
Anthony Romano 2016-12-27 14:48:23 -08:00
parent c00084812c
commit 407afc69ed
1 changed files with 5 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
e2e/ctl_v3_endpoint_test.go
View File

@ -40,15 +40,6 @@ func ctlV3EndpointHealth(cx ctlCtx) error {
return spawnWithExpects(cmdArgs, lines...) return spawnWithExpects(cmdArgs, lines...)
} }
func ctlV3EndpointHealthWithKey(cx ctlCtx, key string) error {
cmdArgs := append(cx.PrefixArgs(), "endpoint", "health", "--health-check-key", key)
lines := make([]string, cx.epc.cfg.clusterSize)
for i := range lines {
lines[i] = "is healthy"
}
return spawnWithExpects(cmdArgs, lines...)
}
func endpointStatusTest(cx ctlCtx) { func endpointStatusTest(cx ctlCtx) {
if err := ctlV3EndpointStatus(cx); err != nil { if err := ctlV3EndpointStatus(cx); err != nil {
cx.t.Fatalf("endpointStatusTest ctlV3EndpointStatus error (%v)", err) cx.t.Fatalf("endpointStatusTest ctlV3EndpointStatus error (%v)", err)
@ -65,15 +56,6 @@ func ctlV3EndpointStatus(cx ctlCtx) error {
return spawnWithExpects(cmdArgs, eps...) return spawnWithExpects(cmdArgs, eps...)
} }
func ctlV3EndpointHealthFailPermissionDenied(cx ctlCtx) error {
cmdArgs := append(cx.PrefixArgs(), "endpoint", "health")
lines := make([]string, cx.epc.cfg.clusterSize)
for i := range lines {
lines[i] = "is unhealthy: failed to commit proposal: etcdserver: permission denied"
}
return spawnWithExpects(cmdArgs, lines...)
}
func endpointHealthTestWithAuth(cx ctlCtx) { func endpointHealthTestWithAuth(cx ctlCtx) {
if err := authEnable(cx); err != nil { if err := authEnable(cx); err != nil {
cx.t.Fatal(err) cx.t.Fatal(err)
@ -86,19 +68,19 @@ func endpointHealthTestWithAuth(cx ctlCtx) {
cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err) cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
} }
// health checking with an ordinal user must fail because the user isn't granted a permission of the key "health" // health checking with an ordinal user "succeeds" since permission denial goes through consensus
cx.user, cx.pass = "test-user", "pass" cx.user, cx.pass = "test-user", "pass"
if err := ctlV3EndpointHealthFailPermissionDenied(cx); err != nil { if err := ctlV3EndpointHealth(cx); err != nil {
cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err) cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
} }
// succeed if permissions granted for ordinary user
cx.user, cx.pass = "root", "root" cx.user, cx.pass = "root", "root"
if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "custom-key", "", false}); err != nil { if err := ctlV3RoleGrantPermission(cx, "test-role", grantingPerm{true, true, "health", "", false}); err != nil {
cx.t.Fatal(err) cx.t.Fatal(err)
} }
cx.user, cx.pass = "test-user", "pass" cx.user, cx.pass = "test-user", "pass"
if err := ctlV3EndpointHealthWithKey(cx, "custom-key"); err != nil { if err := ctlV3EndpointHealth(cx); err != nil {
cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err) cx.t.Fatalf("endpointStatusTest ctlV3EndpointHealth error (%v)", err)
} }
} }