From 52c2a5731f308ebe6998792a4c7785c8e2f37412 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Wed, 24 Jun 2015 12:42:40 -0700 Subject: [PATCH 1/2] etcdserver: fix typo in metrics.go --- etcdserver/metrics.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etcdserver/metrics.go b/etcdserver/metrics.go index 4a9713b61..0544f3f1a 100644 --- a/etcdserver/metrics.go +++ b/etcdserver/metrics.go @@ -47,7 +47,7 @@ var ( fileDescriptorUsed = prometheus.NewGauge(prometheus.GaugeOpts{ Namespace: "etcd", Subsystem: "server", - Name: "file_descriptors_used_totol", + Name: "file_descriptors_used_total", Help: "The total number of file descriptors used.", }) ) From 9aeb181d7543c2187be53ac7a4b4a949643658be Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Wed, 24 Jun 2015 12:44:11 -0700 Subject: [PATCH 2/2] snap: add namespace and subsystem fields for metrics --- snap/metrics.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/snap/metrics.go b/snap/metrics.go index f1a73339c..ee20bf6b6 100644 --- a/snap/metrics.go +++ b/snap/metrics.go @@ -20,8 +20,10 @@ var ( // TODO: save_fsync latency? // TODO: save_encoding latency? saveDurations = prometheus.NewSummary(prometheus.SummaryOpts{ - Name: "snapshot_save_total_durations_microseconds", - Help: "The total latency distributions of save called by snapshot.", + Namespace: "etcd", + Subsystem: "snapshot", + Name: "save_total_durations_microseconds", + Help: "The total latency distributions of save called by snapshot.", }) )