From 32372e1d70df1c20612a080eee50b3f8f0ff8f59 Mon Sep 17 00:00:00 2001 From: Matt Keller Date: Thu, 27 Aug 2015 15:15:34 -0400 Subject: [PATCH 1/3] raft: Fixed a test misassumption network_test.go:56: total = 59.22354ms, want > 50ms 59 is > 50, but the equation added 10 to the right side --- raft/rafttest/network_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/raft/rafttest/network_test.go b/raft/rafttest/network_test.go index 6a2c88116..f5bc16049 100644 --- a/raft/rafttest/network_test.go +++ b/raft/rafttest/network_test.go @@ -52,7 +52,7 @@ func TestNetworkDelay(t *testing.T) { w := time.Duration(float64(sent)*delayrate/2) * delay // there are pretty overhead in the send call, since it genarete random numbers. - if total < w+10*delay { + if total < w { t.Errorf("total = %v, want > %v", total, w) } } From 19a28c8efdc40fb4d173822915401f2e783b2345 Mon Sep 17 00:00:00 2001 From: Matt Keller Date: Thu, 27 Aug 2015 15:20:29 -0400 Subject: [PATCH 2/3] storage: Fixed backend test ./backend_test.go:23: multiple-value batchTx.UnsafeRange() in single-value context --- storage/backend/backend_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage/backend/backend_test.go b/storage/backend/backend_test.go index db5a60f8c..55d9549e2 100644 --- a/storage/backend/backend_test.go +++ b/storage/backend/backend_test.go @@ -20,7 +20,7 @@ func TestBackendPut(t *testing.T) { batchTx.UnsafeCreateBucket([]byte("test")) batchTx.UnsafePut([]byte("test"), []byte("foo"), v) - gv := batchTx.UnsafeRange([]byte("test"), v, nil, -1) + _, gv := batchTx.UnsafeRange([]byte("test"), v, nil, -1) if !reflect.DeepEqual(gv[0], v) { t.Errorf("v = %s, want %s", string(gv[0]), string(v)) } From 327632014ec157123f55fdf33673b7eb2fd9cf66 Mon Sep 17 00:00:00 2001 From: Matt Keller Date: Thu, 27 Aug 2015 15:23:14 -0400 Subject: [PATCH 3/3] cors: Removed new(?) header from test, resolving failure "X-Content-Type-Options" was being autoadded, but none of the test maps took it into account. I saw that "Content-Type" was also being deleted, so I figured that was the best solution for this as well. --- pkg/cors/cors_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/cors/cors_test.go b/pkg/cors/cors_test.go index 4feb072d6..90b6b8b97 100644 --- a/pkg/cors/cors_test.go +++ b/pkg/cors/cors_test.go @@ -117,6 +117,7 @@ func TestCORSHandler(t *testing.T) { } // it is set by http package, and there is no need to test it rr.HeaderMap.Del("Content-Type") + rr.HeaderMap.Del("X-Content-Type-Options") if !reflect.DeepEqual(rr.HeaderMap, tt.wheader) { t.Errorf("#%d: header = %+v, want %+v", i, rr.HeaderMap, tt.wheader) }