From 745cd730a7e0d5b3e010501b29cc497903f03ecc Mon Sep 17 00:00:00 2001 From: James Shubin Date: Fri, 11 Nov 2016 07:33:31 -0500 Subject: [PATCH] embed: Make immutable defaults constant This changes the two immutable defaults into constants which allows packages embedding etcd to import them as const! If they are variables, then you'll fail with "const initializer foo is not a constant". --- embed/config.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/embed/config.go b/embed/config.go index 31a4ce987..ca69b6393 100644 --- a/embed/config.go +++ b/embed/config.go @@ -39,6 +39,9 @@ const ( DefaultMaxSnapshots = 5 DefaultMaxWALs = 5 + DefaultListenPeerURLs = "http://localhost:2380" + DefaultListenClientURLs = "http://localhost:2379" + // maxElectionMs specifies the maximum value of election timeout. // More details are listed in ../Documentation/tuning.md#time-parameters. maxElectionMs = 50000 @@ -49,8 +52,6 @@ var ( "Choose one of \"initial-cluster\", \"discovery\" or \"discovery-srv\"") ErrUnsetAdvertiseClientURLsFlag = fmt.Errorf("--advertise-client-urls is required when --listen-client-urls is set explicitly") - DefaultListenPeerURLs = "http://localhost:2380" - DefaultListenClientURLs = "http://localhost:2379" DefaultInitialAdvertisePeerURLs = "http://localhost:2380" DefaultAdvertiseClientURLs = "http://localhost:2379"