From 4c8fa30ddaf1b74a10f04a9ceb66e73656ecb366 Mon Sep 17 00:00:00 2001 From: Anthony Romano Date: Wed, 13 Sep 2017 09:50:24 -0700 Subject: [PATCH] e2e: test no value is returned in TestCtlV3GetKeysOnly Test was checking key name is returned, but was not correctly checking no value is returned. --- e2e/ctl_v3_kv_test.go | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/e2e/ctl_v3_kv_test.go b/e2e/ctl_v3_kv_test.go index 1fcc38ecc..33b60ae0a 100644 --- a/e2e/ctl_v3_kv_test.go +++ b/e2e/ctl_v3_kv_test.go @@ -198,21 +198,15 @@ func getRevTest(cx ctlCtx) { } func getKeysOnlyTest(cx ctlCtx) { - var ( - kvs = []kv{{"key1", "val1"}} - ) - for i := range kvs { - if err := ctlV3Put(cx, kvs[i].key, kvs[i].val, ""); err != nil { - cx.t.Fatalf("getKeysOnlyTest #%d: ctlV3Put error (%v)", i, err) - } + if err := ctlV3Put(cx, "key", "val", ""); err != nil { + cx.t.Fatal(err) } - - cmdArgs := append(cx.PrefixArgs(), "get") - cmdArgs = append(cmdArgs, []string{"--prefix", "--keys-only", "key"}...) - - err := spawnWithExpects(cmdArgs, []string{"key1", ""}...) - if err != nil { - cx.t.Fatalf("getKeysOnlyTest : error (%v)", err) + cmdArgs := append(cx.PrefixArgs(), []string{"get", "--keys-only", "key"}...) + if err := spawnWithExpect(cmdArgs, "key"); err != nil { + cx.t.Fatal(err) + } + if err := spawnWithExpects(cmdArgs, "val"); err == nil { + cx.t.Fatalf("got value but passed --keys-only") } }