From 54734b0903ac613209757160b3d25e3ef42a2bd4 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Mon, 8 Sep 2014 15:45:58 -0700 Subject: [PATCH] main/wal: add a const for 0700 magic number --- main.go | 7 ++++++- wal/wal.go | 5 ++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/main.go b/main.go index 69579b324..7f79287e1 100644 --- a/main.go +++ b/main.go @@ -17,6 +17,11 @@ import ( "github.com/coreos/etcd/wal" ) +const ( + // the owner can make/remove files inside the directory + privateDirMode = 0700 +) + var ( fid = flag.String("id", "0xBEEF", "Id of this server") timeout = flag.Duration("timeout", 10*time.Second, "Request Timeout") @@ -45,7 +50,7 @@ func main() { *dir = fmt.Sprintf("%v", *fid) log.Printf("main: no data-dir is given, using default data-dir ./%s", *dir) } - if err := os.MkdirAll(*dir, 0700); err != nil { + if err := os.MkdirAll(*dir, privateDirMode); err != nil { log.Fatalf("main: cannot create data directory: %v", err) } diff --git a/wal/wal.go b/wal/wal.go index ba5737d98..3335fb3d1 100644 --- a/wal/wal.go +++ b/wal/wal.go @@ -35,6 +35,9 @@ const ( entryType stateType crcType + + // the owner can make/remove files inside the directory + privateDirMode = 0700 ) var ( @@ -67,7 +70,7 @@ func Create(dirpath string) (*WAL, error) { return nil, os.ErrExist } - if err := os.MkdirAll(dirpath, 0700); err != nil { + if err := os.MkdirAll(dirpath, privateDirMode); err != nil { return nil, err }