Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

etcdctl/ctlv3/command: don't print gRPC WARNING logs by default

Browse Source 
Despite holding important information, these are too noisy.

See https://github.com/coreos/etcd/pull/9623
This commit is contained in:
Eric Chiang 2018-04-25 15:26:54 -07:00
parent 62a385b1ca
commit 55001977ed
No known key found for this signature in database
GPG Key ID: 6CEE575AB0CB7BF9
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
etcdctl/ctlv3/command/global.go
View File

@ -128,9 +128,11 @@ func clientConfigFromCmd(cmd *cobra.Command) *clientConfig {
fmt.Fprintf(os.Stderr, "%s=%v\n", flags.FlagToEnv("ETCDCTL", f.Name), f.Value)
})
} else {
// Enable logging for WARNING and ERROR since these levels include issues with
// connecting to the server, such as TLS misconfiguration.
clientv3.SetLogger(grpclog.NewLoggerV2(ioutil.Discard, os.Stderr, os.Stderr))
// WARNING logs contain important information like TLS misconfirugation, but spams
// too many routine connection disconnects to turn on by default.
//
// See https://github.com/coreos/etcd/pull/9623 for background
clientv3.SetLogger(grpclog.NewLoggerV2(ioutil.Discard, ioutil.Discard, os.Stderr))
}
cfg := &clientConfig{}