change snapshot api due to the change in go-raft

This commit is contained in:
Xiang Li 2013-07-16 18:03:21 -07:00
parent a90f652894
commit 58501151da
5 changed files with 48 additions and 5 deletions

View File

@ -1,6 +1,7 @@
package main package main
import ( import (
"fmt"
"github.com/coreos/etcd/store" "github.com/coreos/etcd/store"
"net/http" "net/http"
"strconv" "strconv"
@ -110,11 +111,12 @@ func dispatch(c Command, w *http.ResponseWriter, req *http.Request, client bool)
return return
} }
(*w).WriteHeader(http.StatusInternalServerError) (*w).WriteHeader(http.StatusInternalServerError)
(*w).Write(newJsonError(300, "No Leader")) (*w).Write(newJsonError(300, err.Error()))
return return
} else { } else {
if body == nil { if body == nil {
fmt.Println("empty but not err!")
http.NotFound((*w), req) http.NotFound((*w), req)
} else { } else {
body, ok := body.([]byte) body, ok := body.([]byte)

View File

@ -120,6 +120,5 @@ func (c *JoinCommand) CommandName() string {
func (c *JoinCommand) Apply(raftServer *raft.Server) (interface{}, error) { func (c *JoinCommand) Apply(raftServer *raft.Server) (interface{}, error) {
err := raftServer.AddPeer(c.Name) err := raftServer.AddPeer(c.Name)
addMachine(c.Name, c.Hostname, c.RaftPort, c.ClientPort) addMachine(c.Name, c.Hostname, c.RaftPort, c.ClientPort)
return []byte("join success"), err return []byte("join success"), err
} }

View File

@ -249,7 +249,7 @@ func startRaft(securityType int) {
err = joinCluster(raftServer, machine) err = joinCluster(raftServer, machine)
if err != nil { if err != nil {
debug("cannot join to cluster via machine %s", machine) debug("cannot join to cluster via machine %s %s", machine, err)
} else { } else {
break break
} }
@ -267,7 +267,7 @@ func startRaft(securityType int) {
} }
// open the snapshot // open the snapshot
// go server.Snapshot() go raftServer.Snapshot()
// start to response to raft requests // start to response to raft requests
go startRaftTransport(info.RaftPort, securityType) go startRaftTransport(info.RaftPort, securityType)
@ -332,6 +332,7 @@ func startRaftTransport(port int, st int) {
http.HandleFunc("/log", GetLogHttpHandler) http.HandleFunc("/log", GetLogHttpHandler)
http.HandleFunc("/log/append", AppendEntriesHttpHandler) http.HandleFunc("/log/append", AppendEntriesHttpHandler)
http.HandleFunc("/snapshot", SnapshotHttpHandler) http.HandleFunc("/snapshot", SnapshotHttpHandler)
http.HandleFunc("/snapshotRecovery", SnapshotRecoveryHttpHandler)
http.HandleFunc("/client", ClientHttpHandler) http.HandleFunc("/client", ClientHttpHandler)
switch st { switch st {
@ -566,6 +567,9 @@ func joinCluster(s *raft.Server, serverName string) error {
json.NewEncoder(&b).Encode(command) json.NewEncoder(&b).Encode(command)
resp, err = t.Post(fmt.Sprintf("%s/join", address), &b) resp, err = t.Post(fmt.Sprintf("%s/join", address), &b)
} else { } else {
b, _ := ioutil.ReadAll(resp.Body)
fmt.Println(string(b))
resp.Body.Close()
return fmt.Errorf("Unable to join") return fmt.Errorf("Unable to join")
} }
} }

View File

@ -61,7 +61,23 @@ func SnapshotHttpHandler(w http.ResponseWriter, req *http.Request) {
err := decodeJsonRequest(req, aereq) err := decodeJsonRequest(req, aereq)
if err == nil { if err == nil {
debug("[recv] POST http://%s/snapshot/ ", raftServer.Name()) debug("[recv] POST http://%s/snapshot/ ", raftServer.Name())
if resp, _ := raftServer.SnapshotRecovery(aereq); resp != nil { if resp := raftServer.SnapshotRequest(aereq); resp != nil {
w.WriteHeader(http.StatusOK)
json.NewEncoder(w).Encode(resp)
return
}
}
warn("[Snapshot] ERROR: %v", err)
w.WriteHeader(http.StatusInternalServerError)
}
// Response to recover from snapshot request
func SnapshotRecoveryHttpHandler(w http.ResponseWriter, req *http.Request) {
aereq := &raft.SnapshotRecoveryRequest{}
err := decodeJsonRequest(req, aereq)
if err == nil {
debug("[recv] POST http://%s/snapshotRecovery/ ", raftServer.Name())
if resp := raftServer.SnapshotRecoveryRequest(aereq); resp != nil {
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
json.NewEncoder(w).Encode(resp) json.NewEncoder(w).Encode(resp)
return return

View File

@ -89,6 +89,28 @@ func (t transporter) SendSnapshotRequest(server *raft.Server, peer *raft.Peer, r
return aersp return aersp
} }
// Sends SnapshotRecoveryRequest RPCs to a peer when the server is the candidate.
func (t transporter) SendSnapshotRecoveryRequest(server *raft.Server, peer *raft.Peer, req *raft.SnapshotRecoveryRequest) *raft.SnapshotRecoveryResponse {
var aersp *raft.SnapshotRecoveryResponse
var b bytes.Buffer
json.NewEncoder(&b).Encode(req)
debug("Send SnapshotRecovery to %s [Last Term: %d, LastIndex %d]", peer.Name(),
req.LastTerm, req.LastIndex)
resp, err := t.Post(fmt.Sprintf("%s/snapshotRecovery", peer.Name()), &b)
if resp != nil {
defer resp.Body.Close()
aersp = &raft.SnapshotRecoveryResponse{}
if err = json.NewDecoder(resp.Body).Decode(&aersp); err == nil || err == io.EOF {
return aersp
}
}
return aersp
}
// Get the client address of the leader in the cluster // Get the client address of the leader in the cluster
func (t transporter) GetLeaderClientAddress() string { func (t transporter) GetLeaderClientAddress() string {
resp, _ := t.Get(raftServer.Leader() + "/client") resp, _ := t.Get(raftServer.Leader() + "/client")