From 62bdcf6f4927faf54d816f84a4f6d60da1489af9 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Tue, 17 Jun 2014 14:51:58 -0700 Subject: [PATCH] raft: range over sm.ins --- raft/raft.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/raft/raft.go b/raft/raft.go index 68ab2c47a..09a567cdf 100644 --- a/raft/raft.go +++ b/raft/raft.go @@ -115,7 +115,7 @@ type stateMachine struct { func newStateMachine(id int, peers []int) *stateMachine { sm := &stateMachine{id: id, log: newLog(), ins: make(map[int]*index)} - for p := range peers { + for _, p := range peers { sm.ins[p] = &index{} } sm.reset(0) @@ -166,9 +166,9 @@ func (sm *stateMachine) bcastAppend() { func (sm *stateMachine) maybeCommit() bool { // TODO(bmizerany): optimize.. Currently naive - mis := make([]int, len(sm.ins)) - for i := range mis { - mis[i] = sm.ins[i].match + mis := make([]int, 0, len(sm.ins)) + for i := range sm.ins { + mis = append(mis, sm.ins[i].match) } sort.Sort(sort.Reverse(sort.IntSlice(mis))) mci := mis[sm.q()-1]