From b4070a28f198cf9dc909920343aa7cd39eb858e7 Mon Sep 17 00:00:00 2001 From: James Blair Date: Tue, 19 Mar 2024 00:27:53 +1300 Subject: [PATCH 1/2] Add 4 more cpu cores to arm64 robustness test workflows. Try to prevent the failures we are seeing regularly for not meeting qps requirements. Signed-off-by: James Blair --- .github/workflows/robustness-nightly.yaml | 4 ++-- .github/workflows/robustness.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/robustness-nightly.yaml b/.github/workflows/robustness-nightly.yaml index bc941cdd7..079054b6d 100644 --- a/.github/workflows/robustness-nightly.yaml +++ b/.github/workflows/robustness-nightly.yaml @@ -29,7 +29,7 @@ jobs: count: 150 testTimeout: 200m artifactName: main-arm64 - runs-on: "['actuated-arm64-8cpu-8gb']" + runs-on: "['actuated-arm64-12cpu-8gb']" scenario: TestRobustnessExploratory lazyfsEnabled: false release-35: @@ -49,7 +49,7 @@ jobs: count: 150 testTimeout: 200m artifactName: release-35-arm64 - runs-on: "['actuated-arm64-8cpu-8gb']" + runs-on: "['actuated-arm64-12cpu-8gb']" scenario: TestRobustnessExploratory lazyfsEnabled: false release-34: diff --git a/.github/workflows/robustness.yaml b/.github/workflows/robustness.yaml index 63df430c2..63ed588da 100644 --- a/.github/workflows/robustness.yaml +++ b/.github/workflows/robustness.yaml @@ -20,6 +20,6 @@ jobs: count: 12 testTimeout: 30m artifactName: main-arm64 - runs-on: "['actuated-arm64-8cpu-8gb']" + runs-on: "['actuated-arm64-12cpu-8gb']" scenario: TestRobustness lazyfsEnabled: false From 64c1acd9b337cdf5dd366dcf5a9787a0faa78332 Mon Sep 17 00:00:00 2001 From: James Blair Date: Tue, 19 Mar 2024 00:31:17 +1300 Subject: [PATCH 2/2] Enable vmmeter to compare performance for robustness runners. Signed-off-by: James Blair --- .github/workflows/robustness-template.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/robustness-template.yaml b/.github/workflows/robustness-template.yaml index 64c4294e7..efe47ba1c 100644 --- a/.github/workflows/robustness-template.yaml +++ b/.github/workflows/robustness-template.yaml @@ -39,6 +39,15 @@ jobs: - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 with: go-version: ${{ steps.goversion.outputs.goversion }} + + # Temporary monitoring to compare amd64 and arm64 runner performance + # Refer: https://actuated.dev/blog/right-sizing-vms-github-actions + - uses: alexellis/setup-arkade@master + - name: Install vmmeter + run: | + sudo -E arkade oci install ghcr.io/openfaasltd/vmmeter:latest --path /usr/local/bin/ + - uses: self-actuated/vmmeter-action@master + - name: install-lazyfs if: ${{ inputs.lazyfsEnabled }} run: |