diff --git a/tests/e2e/cluster_downgrade_test.go b/tests/e2e/cluster_downgrade_test.go index a36a7b403..fb6f7d954 100644 --- a/tests/e2e/cluster_downgrade_test.go +++ b/tests/e2e/cluster_downgrade_test.go @@ -23,7 +23,6 @@ import ( "time" "github.com/coreos/go-semver/semver" - "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "go.uber.org/zap" @@ -155,8 +154,7 @@ func startEtcd(t *testing.T, ep e2e.EtcdProcess, execPath string) { } func downgradeEnable(t *testing.T, epc *e2e.EtcdProcessCluster, ver *semver.Version) { - c, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - assert.NoError(t, err) + c := epc.Etcdctl() testutils.ExecuteWithTimeout(t, 20*time.Second, func() { err := c.DowngradeEnable(context.TODO(), ver.String()) if err != nil { diff --git a/tests/e2e/corrupt_test.go b/tests/e2e/corrupt_test.go index 94ee2084c..e7c99bcea 100644 --- a/tests/e2e/corrupt_test.go +++ b/tests/e2e/corrupt_test.go @@ -117,9 +117,7 @@ func TestPeriodicCheckDetectsCorruption(t *testing.T) { } }) - cc, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - assert.NoError(t, err) - + cc := epc.Etcdctl() for i := 0; i < 10; i++ { err := cc.Put(ctx, testutil.PickKey(int64(i)), fmt.Sprint(i), config.PutOptions{}) assert.NoError(t, err, "error on put") @@ -165,9 +163,7 @@ func TestCompactHashCheckDetectCorruption(t *testing.T) { } }) - cc, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - assert.NoError(t, err) - + cc := epc.Etcdctl() for i := 0; i < 10; i++ { err := cc.Put(ctx, testutil.PickKey(int64(i)), fmt.Sprint(i), config.PutOptions{}) assert.NoError(t, err, "error on put") @@ -236,8 +232,7 @@ func TestCompactHashCheckDetectCorruptionInterrupt(t *testing.T) { // Put 10 identical keys to the cluster, so that the compaction will drop some stale values. t.Log("putting 10 values to the identical key...") - cc, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - require.NoError(t, err) + cc := epc.Etcdctl() for i := 0; i < 10; i++ { err := cc.Put(ctx, "key", fmt.Sprint(i), config.PutOptions{}) require.NoError(t, err, "error on put") diff --git a/tests/e2e/etcd_config_test.go b/tests/e2e/etcd_config_test.go index e0d522df3..b3df0eeae 100644 --- a/tests/e2e/etcd_config_test.go +++ b/tests/e2e/etcd_config_test.go @@ -411,12 +411,9 @@ func TestEtcdHealthyWithTinySnapshotCatchupEntries(t *testing.T) { for i := 0; i < 10; i++ { clientId := i g.Go(func() error { - cc, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - if err != nil { - return err - } + cc := epc.Etcdctl() for j := 0; j < 100; j++ { - if err = cc.Put(ctx, "foo", fmt.Sprintf("bar%d", clientId), config.PutOptions{}); err != nil { + if err := cc.Put(ctx, "foo", fmt.Sprintf("bar%d", clientId), config.PutOptions{}); err != nil { return err } } diff --git a/tests/e2e/promote_experimental_flag_test.go b/tests/e2e/promote_experimental_flag_test.go index 53c59d526..0555cf9b9 100644 --- a/tests/e2e/promote_experimental_flag_test.go +++ b/tests/e2e/promote_experimental_flag_test.go @@ -20,7 +20,6 @@ import ( "time" "github.com/stretchr/testify/assert" - "github.com/stretchr/testify/require" "go.etcd.io/etcd/tests/v3/framework/config" "go.etcd.io/etcd/tests/v3/framework/e2e" @@ -42,8 +41,7 @@ func TestWarningApplyDuration(t *testing.T) { } }) - cc, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - require.NoError(t, err) + cc := epc.Etcdctl() err = cc.Put(context.TODO(), "foo", "bar", config.PutOptions{}) assert.NoError(t, err, "error on put") @@ -70,8 +68,7 @@ func TestExperimentalWarningApplyDuration(t *testing.T) { } }) - cc, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - require.NoError(t, err) + cc := epc.Etcdctl() err = cc.Put(context.TODO(), "foo", "bar", config.PutOptions{}) assert.NoError(t, err, "error on put") diff --git a/tests/e2e/v2store_deprecation_test.go b/tests/e2e/v2store_deprecation_test.go index cb4dea9cc..432a61b2a 100644 --- a/tests/e2e/v2store_deprecation_test.go +++ b/tests/e2e/v2store_deprecation_test.go @@ -115,14 +115,12 @@ func TestV2DeprecationSnapshotMatches(t *testing.T) { var snapshotCount uint64 = 10 epc := runEtcdAndCreateSnapshot(t, e2e.LastVersion, lastReleaseData, snapshotCount) oldMemberDataDir := epc.Procs[0].Config().DataDirPath - cc1, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - assert.NoError(t, err) + cc1 := epc.Etcdctl() members1 := addAndRemoveKeysAndMembers(ctx, t, cc1, snapshotCount) assert.NoError(t, epc.Close()) epc = runEtcdAndCreateSnapshot(t, e2e.CurrentVersion, currentReleaseData, snapshotCount) newMemberDataDir := epc.Procs[0].Config().DataDirPath - cc2, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - assert.NoError(t, err) + cc2 := epc.Etcdctl() members2 := addAndRemoveKeysAndMembers(ctx, t, cc2, snapshotCount) assert.NoError(t, epc.Close()) @@ -152,9 +150,7 @@ func TestV2DeprecationSnapshotRecover(t *testing.T) { } epc := runEtcdAndCreateSnapshot(t, e2e.LastVersion, dataDir, 10) - cc, err := e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - assert.NoError(t, err) - + cc := epc.Etcdctl() lastReleaseGetResponse, err := cc.Get(ctx, "", config.GetOptions{Prefix: true}) assert.NoError(t, err) @@ -169,8 +165,7 @@ func TestV2DeprecationSnapshotRecover(t *testing.T) { epc, err = e2e.NewEtcdProcessCluster(context.TODO(), t, e2e.WithConfig(cfg)) assert.NoError(t, err) - cc, err = e2e.NewEtcdctl(epc.Cfg.Client, epc.EndpointsGRPC()) - assert.NoError(t, err) + cc = epc.Etcdctl() currentReleaseGetResponse, err := cc.Get(ctx, "", config.GetOptions{Prefix: true}) assert.NoError(t, err)