From 6d77e4dfd6b6e69d9eee9fa66e0a4e07837bca16 Mon Sep 17 00:00:00 2001 From: Yicheng Qin Date: Wed, 9 Apr 2014 13:11:23 -0700 Subject: [PATCH] fix(fs): rewrite test to avoid side effect --- pkg/fs/fs_test.go | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/pkg/fs/fs_test.go b/pkg/fs/fs_test.go index 5098b3ebc..32f2e2507 100644 --- a/pkg/fs/fs_test.go +++ b/pkg/fs/fs_test.go @@ -1,21 +1,30 @@ package fs import ( + "io/ioutil" + "os" "os/exec" "strings" "testing" ) func TestSetNOCOW(t *testing.T) { - if IsBtrfs("/") { - SetNOCOW("/") - cmd := exec.Command("lsattr", "/") + f, err := ioutil.TempFile(".", "etcdtest") + if err != nil { + t.Fatal("Failed creating temp file") + } + f.Close() + defer os.Remove(f.Name()) + + if IsBtrfs(f.Name()) { + SetNOCOW(f.Name()) + cmd := exec.Command("lsattr", f.Name()) out, err := cmd.Output() if err != nil { t.Fatal("Failed executing lsattr") } - if strings.Contains(string(out), "---------------C") { - t.Fatal("Failed setting NOCOW:\n", out) + if !strings.Contains(string(out), "---------------C") { + t.Fatal("Failed setting NOCOW:\n", string(out)) } } }