Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8546 from heyitsanthony/receiver-ci

Browse Source 
test: check for inconsistent receiver names
This commit is contained in:
Anthony Romano 2017-09-12 13:59:52 -07:00 committed by GitHub
commit 6f6279075a
5 changed files with 26 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clientv3/concurrency/election.go
View File

@ -242,4 +242,4 @@ func (e *Election) Key() string { return e.leaderKey }
func (e *Election) Rev() int64 { return e.leaderRev } func (e *Election) Rev() int64 { return e.leaderRev }
// Header is the response header from the last successful election proposal. // Header is the response header from the last successful election proposal.
func (m *Election) Header() *pb.ResponseHeader { return m.hdr } func (e *Election) Header() *pb.ResponseHeader { return e.hdr }

4
clientv3/namespace/kv.go
View File

@ -180,8 +180,8 @@ func (kv *kvPrefix) unprefixTxnResponse(resp *clientv3.TxnResponse) {
} }
} }
func (p *kvPrefix) prefixInterval(key, end []byte) (pfxKey []byte, pfxEnd []byte) { func (kv *kvPrefix) prefixInterval(key, end []byte) (pfxKey []byte, pfxEnd []byte) {
return prefixInterval(p.pfx, key, end) return prefixInterval(kv.pfx, key, end)
} }
func (kv *kvPrefix) prefixCmps(cs []clientv3.Cmp) []clientv3.Cmp { func (kv *kvPrefix) prefixCmps(cs []clientv3.Cmp) []clientv3.Cmp {

6
mvcc/index.go
View File

@ -221,16 +221,16 @@ func compactIndex(rev int64, available map[revision]struct{}, emptyki *[]*keyInd
} }
} }
func (a *treeIndex) Equal(bi index) bool { func (ti *treeIndex) Equal(bi index) bool {
b := bi.(*treeIndex) b := bi.(*treeIndex)
if a.tree.Len() != b.tree.Len() { if ti.tree.Len() != b.tree.Len() {
return false return false
} }
equal := true equal := true
a.tree.Ascend(func(item btree.Item) bool { ti.tree.Ascend(func(item btree.Item) bool {
aki := item.(*keyIndex) aki := item.(*keyIndex)
bki := b.tree.Get(item).(*keyIndex) bki := b.tree.Get(item).(*keyIndex)
if !aki.equal(bki) { if !aki.equal(bki) {

14
pkg/report/timeseries.go
View File

@ -118,20 +118,20 @@ func (sp *secondPoints) getTimeSeries() TimeSeries {
return tslice return tslice
} }
func (ts TimeSeries) String() string { func (t TimeSeries) String() string {
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
wr := csv.NewWriter(buf) wr := csv.NewWriter(buf)
if err := wr.Write([]string{"UNIX-SECOND", "MIN-LATENCY-MS", "AVG-LATENCY-MS", "MAX-LATENCY-MS", "AVG-THROUGHPUT"}); err != nil { if err := wr.Write([]string{"UNIX-SECOND", "MIN-LATENCY-MS", "AVG-LATENCY-MS", "MAX-LATENCY-MS", "AVG-THROUGHPUT"}); err != nil {
log.Fatal(err) log.Fatal(err)
} }
rows := [][]string{} rows := [][]string{}
for i := range ts { for i := range t {
row := []string{ row := []string{
fmt.Sprintf("%d", ts[i].Timestamp), fmt.Sprintf("%d", t[i].Timestamp),
ts[i].MinLatency.String(), t[i].MinLatency.String(),
ts[i].AvgLatency.String(), t[i].AvgLatency.String(),
ts[i].MaxLatency.String(), t[i].MaxLatency.String(),
fmt.Sprintf("%d", ts[i].ThroughPut), fmt.Sprintf("%d", t[i].ThroughPut),
} }
rows = append(rows, row) rows = append(rows, row)
} }

13
test
View File

@ -397,6 +397,19 @@ function fmt_pass {
exit 255 exit 255
fi fi
echo "Checking receiver names..."
recvs=$(grep 'func ([^*]' {*,*/*,*/*/*}.go | grep -Ev "(generated|pb/)" | tr ':' ' ' | \
awk ' { print $2" "$3" "$4" "$1 }' | sed "s/[a-zA-Z\.]*go//g" | sort | uniq | \
grep -Ev "(Descriptor|Proto|_)" | awk ' { print $3" "$4 } ' | sort | uniq -c | grep -v ' 1 ' | awk ' { print $2 } ')
if [ -n "${recvs}" ]; then
recvs=($recvs)
for recv in "${recvs[@]}"; do
echo "Mismatched receiver for $recv..."
grep "$recv" "${FMT[@]}" | grep 'func ('
done
exit 255
fi
echo "Checking commit titles..." echo "Checking commit titles..."
git log --oneline "$(git merge-base HEAD master)"...HEAD | while read -r l; do git log --oneline "$(git merge-base HEAD master)"...HEAD | while read -r l; do
commitMsg=$(echo "$l" | cut -f2- -d' ') commitMsg=$(echo "$l" | cut -f2- -d' ')