From a26cb976c537f0b6e0d01c7ee61e72e52a1d7d00 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Wed, 10 Jul 2013 20:14:32 -0700 Subject: [PATCH 1/2] clean up prints and fix len problem --- etcd.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/etcd.go b/etcd.go index b30a03339..cb927ad5a 100644 --- a/etcd.go +++ b/etcd.go @@ -206,7 +206,7 @@ func startRaft(securityType int) { if raftServer.IsLogEmpty() { // start as a leader in a new cluster - if len(cluster) == 0 { + if len(cluster) == 1 && cluster[0] == "" { raftServer.StartLeader() time.Sleep(time.Millisecond * 20) @@ -518,10 +518,7 @@ func joinCluster(s *raft.Server, serverName string) error { resp, err := t.Post(fmt.Sprintf("%s/join", serverName), &b) - debug("Finish Join Request to %s", serverName) - for { - fmt.Println(err, resp) if err != nil { return fmt.Errorf("Unable to join: %v", err) } @@ -530,14 +527,14 @@ func joinCluster(s *raft.Server, serverName string) error { if resp.StatusCode == http.StatusOK { return nil } - if resp.StatusCode == http.StatusTemporaryRedirect { - fmt.Println("redirect") address = resp.Header.Get("Location") debug("Leader is %s", address) debug("Send Join Request to %s", address) json.NewEncoder(&b).Encode(command) resp, err = t.Post(fmt.Sprintf("%s/join", address), &b) + } else { + return fmt.Errorf("Unable to join") } } From c2a80df3f940f8c2e1271bb28f44a0e82275c783 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Wed, 10 Jul 2013 20:19:34 -0700 Subject: [PATCH 2/2] fix redeclear err --- etcd.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etcd.go b/etcd.go index cb927ad5a..a2d840cc8 100644 --- a/etcd.go +++ b/etcd.go @@ -228,7 +228,7 @@ func startRaft(securityType int) { for _, machine := range cluster { - err := joinCluster(raftServer, machine) + err = joinCluster(raftServer, machine) if err != nil { debug("cannot join to cluster via machine %s", machine) } else {