Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

rafthttp: only use pipeline to send MsgSnap

Browse Source 
The size of MsgSnap may be very big, e.g., 1G.
If its size is big and general streaming is used to send it, it may block
the following messages for several ten seconds, which interrupts the
heartbeat heavily.
Only use pipeline to send MsgSnap.
This commit is contained in:
Yicheng Qin 2015-03-01 07:15:19 -08:00
parent 9989bf1d36
commit 78aa251ab2
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rafthttp/peer.go
View File

@ -180,6 +180,11 @@ func (p *peer) Stop() {
func (p *peer) pick(m raftpb.Message) (writec chan raftpb.Message, name string, size int) {
switch {
// Considering MsgSnap may have a big size, e.g., 1G, and will block
// stream for a long time, only use one of the N pipelines to send MsgSnap.
case isMsgSnap(m):
writec = p.pipeline.msgc
name, size = "pipeline", pipelineBufSize
case p.msgAppWriter.isWorking() && canUseMsgAppStream(m):
writec = p.msgAppWriter.msgc
name, size = "msgapp stream", streamBufSize
@ -192,3 +197,5 @@ func (p *peer) pick(m raftpb.Message) (writec chan raftpb.Message, name string,
}
return
}
func isMsgSnap(m raftpb.Message) bool { return m.Type == raftpb.MsgSnap }