From 7a698be6a3cdbfad4f4c385e2b20eadf07b50533 Mon Sep 17 00:00:00 2001 From: Yicheng Qin Date: Wed, 1 Oct 2014 11:07:32 -0700 Subject: [PATCH] main: not use loop variable in goroutine in loop body Because loop variable are reused in following loops. --- main.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/main.go b/main.go index fe2f335eb..8e3fac9d9 100644 --- a/main.go +++ b/main.go @@ -220,8 +220,9 @@ func startEtcd() { } // Start the peer server in a goroutine + urlStr := u.String() go func() { - log.Print("Listening for peers on ", u.String()) + log.Print("Listening for peers on ", urlStr) log.Fatal(http.Serve(l, ph)) }() } @@ -233,8 +234,9 @@ func startEtcd() { log.Fatal(err) } + urlStr := u.String() go func() { - log.Print("Listening for client requests on ", u.String()) + log.Print("Listening for client requests on ", urlStr) log.Fatal(http.Serve(l, ch)) }() } @@ -268,8 +270,9 @@ func startProxy() { log.Fatal(err) } + host := u.Host go func() { - log.Print("Listening for client requests on ", u.Host) + log.Print("Listening for client requests on ", host) log.Fatal(http.Serve(l, ph)) }() }