From 82ddeb38b48deff9f9744e649af0cf3d47710e77 Mon Sep 17 00:00:00 2001 From: Anthony Romano Date: Wed, 20 Jul 2016 09:55:39 -0700 Subject: [PATCH] integration: fix race in TestV3WatchMultipleEventsTxnSynced Writes between watcher creation request and reply were being dropped. Fixes #5789 --- integration/v3_watch_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/integration/v3_watch_test.go b/integration/v3_watch_test.go index 08cb565c9..e75306a19 100644 --- a/integration/v3_watch_test.go +++ b/integration/v3_watch_test.go @@ -672,6 +672,9 @@ func testV3WatchMultipleEventsTxn(t *testing.T, startRev int64) { if err := wStream.Send(wreq); err != nil { t.Fatalf("wStream.Send error: %v", err) } + if resp, err := wStream.Recv(); err != nil || resp.Created == false { + t.Fatalf("create response failed: resp=%v, err=%v", resp, err) + } kvc := toGRPC(clus.RandClient()).KV txn := pb.TxnRequest{} @@ -697,9 +700,6 @@ func testV3WatchMultipleEventsTxn(t *testing.T, startRev int64) { if err != nil { t.Errorf("wStream.Recv error: %v", err) } - if resp.Created { - continue - } events = append(events, resp.Events...) } sort.Sort(eventsSortByKey(events))