diff --git a/tests/e2e/v3_curl_kv_test.go b/tests/e2e/v3_curl_kv_test.go index 147fe0283..e0a3c2f54 100644 --- a/tests/e2e/v3_curl_kv_test.go +++ b/tests/e2e/v3_curl_kv_test.go @@ -183,7 +183,7 @@ func mustExecuteTxn(cx ctlCtx, reqData string) (bool, []any) { clus := cx.epc args := e2e.CURLPrefixArgsCluster(clus.Cfg, clus.Procs[0], "POST", e2e.CURLReq{ Endpoint: "/v3/kv/txn", - Value: string(reqData), + Value: reqData, }) resp, err := runCommandAndReadJsonOutput(args) require.NoError(cx.t, err) diff --git a/tests/framework/integration/integration.go b/tests/framework/integration/integration.go index 6e182e7f1..6be69ad8a 100644 --- a/tests/framework/integration/integration.go +++ b/tests/framework/integration/integration.go @@ -53,7 +53,7 @@ func (e integrationRunner) NewCluster(ctx context.Context, t testing.TB, opts .. QuotaBackendBytes: cfg.QuotaBackendBytes, DisableStrictReconfigCheck: !cfg.StrictReconfigCheck, AuthToken: cfg.AuthToken, - SnapshotCount: uint64(cfg.SnapshotCount), + SnapshotCount: cfg.SnapshotCount, } integrationCfg.ClientTLS, err = tlsInfo(t, cfg.ClientTLS) if err != nil { diff --git a/tests/integration/clientv3/naming/resolver_test.go b/tests/integration/clientv3/naming/resolver_test.go index fc7ba077e..814ed7768 100644 --- a/tests/integration/clientv3/naming/resolver_test.go +++ b/tests/integration/clientv3/naming/resolver_test.go @@ -126,7 +126,7 @@ func testEtcdGrpcResolver(t *testing.T, lbPolicy string) { // Allow 25% tolerance as round robin is not perfect and we don't want the test to flake expected := float64(totalRequests) * 0.5 - assert.InEpsilon(t, float64(expected), float64(responses), 0.25, "unexpected total responses from foo: %s", string(lastResponse)) + assert.InEpsilon(t, expected, float64(responses), 0.25, "unexpected total responses from foo: %s", string(lastResponse)) } } diff --git a/tools/.golangci.yaml b/tools/.golangci.yaml index 068584cc8..e82199541 100644 --- a/tools/.golangci.yaml +++ b/tools/.golangci.yaml @@ -23,7 +23,7 @@ linters: - staticcheck - stylecheck - unused - # - unconvert # Remove unnecessary type conversions TODO: enable by #16610 + - unconvert # Remove unnecessary type conversions linters-settings: # please keep this alphabetized goimports: local-prefixes: go.etcd.io # Put imports beginning with prefix after 3rd-party packages.