diff --git a/client/v3/ordering/kv_test.go b/client/v3/ordering/kv_test.go index 2168c3157..cb6d0d390 100644 --- a/client/v3/ordering/kv_test.go +++ b/client/v3/ordering/kv_test.go @@ -16,7 +16,6 @@ package ordering import ( "context" - gContext "context" "sync" "testing" @@ -29,7 +28,7 @@ type mockKV struct { response clientv3.OpResponse } -func (kv *mockKV) Do(ctx gContext.Context, op clientv3.Op) (clientv3.OpResponse, error) { +func (kv *mockKV) Do(ctx context.Context, op clientv3.Op) (clientv3.OpResponse, error) { return kv.response, nil } diff --git a/server/etcdserver/api/etcdhttp/health.go b/server/etcdserver/api/etcdhttp/health.go index 95950de89..4d6698786 100644 --- a/server/etcdserver/api/etcdhttp/health.go +++ b/server/etcdserver/api/etcdhttp/health.go @@ -23,7 +23,6 @@ import ( "github.com/prometheus/client_golang/prometheus" "go.uber.org/zap" - "go.etcd.io/etcd/api/v3/etcdserverpb" pb "go.etcd.io/etcd/api/v3/etcdserverpb" "go.etcd.io/etcd/client/pkg/v3/types" "go.etcd.io/etcd/server/v3/auth" @@ -154,9 +153,9 @@ func checkAlarms(lg *zap.Logger, srv ServerHealth, excludedAlarms AlarmSet) Heal h.Health = "false" switch v.Alarm { - case etcdserverpb.AlarmType_NOSPACE: + case pb.AlarmType_NOSPACE: h.Reason = "ALARM NOSPACE" - case etcdserverpb.AlarmType_CORRUPT: + case pb.AlarmType_CORRUPT: h.Reason = "ALARM CORRUPT" default: h.Reason = "ALARM UNKNOWN" @@ -183,7 +182,7 @@ func checkAPI(lg *zap.Logger, srv ServerHealth, serializable bool) Health { h := Health{Health: "true"} cfg := srv.Config() ctx, cancel := context.WithTimeout(context.Background(), cfg.ReqTimeout()) - _, err := srv.Range(ctx, &etcdserverpb.RangeRequest{KeysOnly: true, Limit: 1, Serializable: serializable}) + _, err := srv.Range(ctx, &pb.RangeRequest{KeysOnly: true, Limit: 1, Serializable: serializable}) cancel() if err != nil && err != auth.ErrUserEmpty && err != auth.ErrPermissionDenied { h.Health = "false" diff --git a/tools/.golangci.yaml b/tools/.golangci.yaml index 9eb67f303..1f1f9b62a 100644 --- a/tools/.golangci.yaml +++ b/tools/.golangci.yaml @@ -21,7 +21,7 @@ linters: - ineffassign - revive - staticcheck - # - stylecheck # TODO: enable by #16610 + - stylecheck # - unused # TODO: enable by #16610 # - unconvert # Remove unnecessary type conversions TODO: enable by #16610 linters-settings: # please keep this alphabetized