Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

wal: reduce allocation when encoding int64

Browse Source
This commit is contained in:
Xiang Li 2015-03-30 20:41:31 -07:00
parent 2990c29a71
commit 8bcaa2bfdf
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
wal/encoder.go
View File

@ -29,8 +29,9 @@ type encoder struct {
mu sync.Mutex
bw *bufio.Writer
crc hash.Hash32
buf []byte
crc hash.Hash32
buf []byte
uint64buf []byte
}
func newEncoder(w io.Writer, prevCrc uint32) *encoder {
@ -38,7 +39,8 @@ func newEncoder(w io.Writer, prevCrc uint32) *encoder {
bw: bufio.NewWriter(w),
crc: crc.New(prevCrc, crcTable),
// 1MB buffer
buf: make([]byte, 1024*1024),
buf: make([]byte, 1024*1024),
uint64buf: make([]byte, 8),
}
}
@ -66,7 +68,7 @@ func (e *encoder) encode(rec *walpb.Record) error {
}
data = e.buf[:n]
}
if err := writeInt64(e.bw, int64(len(data))); err != nil {
if err := writeInt64(e.bw, int64(len(data)), e.uint64buf); err != nil {
return err
}
_, err = e.bw.Write(data)
@ -79,7 +81,9 @@ func (e *encoder) flush() error {
return e.bw.Flush()
}
func writeInt64(w io.Writer, n int64) error {
// TODO: use putuint64 to reduce two alloctions
return binary.Write(w, binary.LittleEndian, n)
func writeInt64(w io.Writer, n int64, buf []byte) error {
// http://golang.org/src/encoding/binary/binary.go
binary.LittleEndian.PutUint64(buf, uint64(n))
_, err := w.Write(buf)
return err
}