Merge pull request #10945 from tbg/add-todo

raft: leave TODO about leaving StateSnapshot
This commit is contained in:
Gyuho Lee 2019-07-29 13:51:38 -07:00 committed by GitHub
commit 936c506e8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1093,6 +1093,9 @@ func stepLeader(r *raft, m pb.Message) error {
case pr.State == tracker.StateProbe:
pr.BecomeReplicate()
case pr.State == tracker.StateSnapshot && pr.Match >= pr.PendingSnapshot:
// TODO(tbg): we should also enter this branch if a snapshot is
// received that is below pr.PendingSnapshot but which makes it
// possible to use the log again.
r.logger.Debugf("%x recovered from needing snapshot, resumed sending replication messages to %x [%s]", r.id, m.From, pr)
// Transition back to replicating state via probing state
// (which takes the snapshot into account). If we didn't