Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12481 from kalexmills/fix-defer-log

Browse Source 
fix: pass argument url in defer to avoid loopclosure
This commit is contained in:
Piotr Tabor 2021-01-31 23:20:32 +01:00 committed by GitHub
commit 958f6f9878
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/embed/etcd.go
View File

@ -589,7 +589,7 @@ func configureClientListeners(cfg *Config) (sctxs map[string]*serveCtx, err erro
} }
} }
defer func() { defer func(u url.URL) {
if err == nil { if err == nil {
return return
} }
@ -599,7 +599,7 @@ func configureClientListeners(cfg *Config) (sctxs map[string]*serveCtx, err erro
zap.String("address", u.Host), zap.String("address", u.Host),
zap.Error(err), zap.Error(err),
) )
}() }(u)
for k := range cfg.UserHandlers { for k := range cfg.UserHandlers {
sctx.userHandlers[k] = cfg.UserHandlers[k] sctx.userHandlers[k] = cfg.UserHandlers[k]
} }