Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5065 from heyitsanthony/errexit-defrag

Browse Source 
etcdctl: return non-zero exit code if defrag fails on any endpoint
This commit is contained in:
Anthony Romano 2016-04-13 13:19:43 -07:00
commit 993f25f055
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
etcdctl/ctlv3/command/defrag_command.go
View File

@ -31,6 +31,7 @@ func NewDefragCommand() *cobra.Command {
} }
func defragCommandFunc(cmd *cobra.Command, args []string) { func defragCommandFunc(cmd *cobra.Command, args []string) {
failures := 0
c := mustClientFromCmd(cmd) c := mustClientFromCmd(cmd)
for _, ep := range c.Endpoints() { for _, ep := range c.Endpoints() {
ctx, cancel := commandCtx(cmd) ctx, cancel := commandCtx(cmd)
@ -38,8 +39,13 @@ func defragCommandFunc(cmd *cobra.Command, args []string) {
cancel() cancel()
if err != nil { if err != nil {
fmt.Fprintf(os.Stderr, "Failed to defragment etcd member[%s] (%v)\n", ep, err) fmt.Fprintf(os.Stderr, "Failed to defragment etcd member[%s] (%v)\n", ep, err)
failures++
} else { } else {
fmt.Printf("Finished defragmenting etcd member[%s]\n", ep) fmt.Printf("Finished defragmenting etcd member[%s]\n", ep)
} }
} }
if failures != 0 {
os.Exit(ExitError)
}
} }