Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

mvcc/backend: add "etcd_disk_backend_defrag_duration_seconds"

Browse Source 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
This commit is contained in:
Gyuho Lee 2018-05-23 12:21:57 -07:00 committed by Wenjia Zhang
parent 22c25dd4e7
commit 9f58e57a3c
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mvcc/backend/backend.go
View File

@ -229,6 +229,8 @@ func (b *backend) Defrag() error {
} }
func (b *backend) defrag() error { func (b *backend) defrag() error {
now := time.Now()
// TODO: make this non-blocking? // TODO: make this non-blocking?
// lock batchTx to ensure nobody is using previous tx, and then // lock batchTx to ensure nobody is using previous tx, and then
// close previous ongoing tx. // close previous ongoing tx.
@ -285,6 +287,9 @@ func (b *backend) defrag() error {
atomic.StoreInt64(&b.size, size) atomic.StoreInt64(&b.size, size)
atomic.StoreInt64(&b.sizeInUse, size-(int64(db.Stats().FreePageN)*int64(db.Info().PageSize))) atomic.StoreInt64(&b.sizeInUse, size-(int64(db.Stats().FreePageN)*int64(db.Info().PageSize)))
took := time.Since(now)
defragDurations.Observe(took.Seconds())
return nil return nil
} }

13
mvcc/backend/metrics.go
View File

@ -27,8 +27,21 @@ var (
// highest bucket start of 0.001 sec * 2^13 == 8.192 sec // highest bucket start of 0.001 sec * 2^13 == 8.192 sec
Buckets: prometheus.ExponentialBuckets(0.001, 2, 14), Buckets: prometheus.ExponentialBuckets(0.001, 2, 14),
}) })
defragDurations = prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: "etcd",
Subsystem: "disk",
Name: "backend_defrag_duration_seconds",
Help: "The latency distribution of backend defragmentation.",
// 100 MB usually takes 1 sec, so start with 10 MB of 100 ms
// lowest bucket start of upper bound 0.1 sec (100 ms) with factor 2
// highest bucket start of 0.1 sec * 2^12 == 409.6 sec
Buckets: prometheus.ExponentialBuckets(.01, 2, 13),
})
) )
func init() { func init() {
prometheus.MustRegister(commitDurations) prometheus.MustRegister(commitDurations)
prometheus.MustRegister(defragDurations)
} }