From a066b03c2c8f520f2aa7a2a753cd154b05099163 Mon Sep 17 00:00:00 2001 From: Gyuho Lee Date: Mon, 26 Mar 2018 17:19:12 -0700 Subject: [PATCH] embed: clean up CORS, HostWhitelist logging Signed-off-by: Gyuho Lee --- embed/etcd.go | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/embed/etcd.go b/embed/etcd.go index 58449a2f8..04e743ded 100644 --- a/embed/etcd.go +++ b/embed/etcd.go @@ -180,7 +180,23 @@ func StartEtcd(inCfg *Config) (e *Etcd, err error) { if e.Server, err = etcdserver.NewServer(srvcfg); err != nil { return e, err } - plog.Infof("%s starting with host whitelist %q", e.Server.ID(), cfg.HostWhitelist) + + if len(e.cfg.CORS) > 0 { + ss := make([]string, 0, len(e.cfg.CORS)) + for v := range e.cfg.CORS { + ss = append(ss, v) + } + sort.Strings(ss) + plog.Infof("%s starting with cors %q", e.Server.ID(), ss) + } + if len(e.cfg.HostWhitelist) > 0 { + ss := make([]string, 0, len(e.cfg.HostWhitelist)) + for v := range e.cfg.HostWhitelist { + ss = append(ss, v) + } + sort.Strings(ss) + plog.Infof("%s starting with host whitelist %q", e.Server.ID(), ss) + } // buffer channel so goroutines on closed connections won't wait forever e.errc = make(chan error, len(e.Peers)+len(e.Clients)+2*len(e.sctxs)) @@ -474,15 +490,6 @@ func (e *Etcd) serveClients() (err error) { plog.Infof("ClientTLS: %s", e.cfg.ClientTLSInfo) } - if len(e.cfg.CORS) > 0 { - ss := make([]string, 0, len(e.cfg.CORS)) - for v := range e.cfg.CORS { - ss = append(ss, v) - } - sort.Strings(ss) - plog.Infof("cors = %q", ss) - } - // Start a client server goroutine for each listen address var h http.Handler if e.Config().EnableV2 {