From a1cb5cb76845b596cfdde5d1b52b6ff5b2e9c549 Mon Sep 17 00:00:00 2001 From: Yicheng Qin Date: Fri, 20 Mar 2015 17:01:53 -0700 Subject: [PATCH] etcdmain: print error when non-flag args remain --- etcdmain/config.go | 3 +++ etcdmain/etcd.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/etcdmain/config.go b/etcdmain/config.go index df3dbf123..d1044855a 100644 --- a/etcdmain/config.go +++ b/etcdmain/config.go @@ -208,6 +208,9 @@ func (cfg *config) Parse(arguments []string) error { default: os.Exit(2) } + if len(cfg.FlagSet.Args()) != 0 { + return fmt.Errorf("'%s' is not a valid flag", cfg.FlagSet.Arg(0)) + } if cfg.printVersion { fmt.Println("etcd version", version.Version) diff --git a/etcdmain/etcd.go b/etcdmain/etcd.go index 0aa31742e..ee27e5047 100644 --- a/etcdmain/etcd.go +++ b/etcdmain/etcd.go @@ -56,7 +56,7 @@ func Main() { cfg := NewConfig() err := cfg.Parse(os.Args[1:]) if err != nil { - log.Printf("etcd: error verifying flags, %v", err) + log.Printf("etcd: error verifying flags, %v. See 'etcd -help'.", err) os.Exit(2) }