Raft fixes, integrate logging.

This commit is contained in:
Ben Johnson
2013-12-27 15:35:42 -07:00
parent 44af8ea190
commit a9e20aecc6
10 changed files with 30 additions and 30 deletions

View File

@@ -37,11 +37,11 @@ func (c *JoinCommand) CommandName() string {
}
// Join a server to the cluster
func (c *JoinCommand) Apply(server raft.Server) (interface{}, error) {
ps, _ := server.Context().(*PeerServer)
func (c *JoinCommand) Apply(context raft.Context) (interface{}, error) {
ps, _ := context.Server().Context().(*PeerServer)
b := make([]byte, 8)
binary.PutUvarint(b, server.CommitIndex())
binary.PutUvarint(b, context.CommitIndex())
// Make sure we're not getting a cached value from the registry.
ps.registry.Invalidate(c.Name)
@@ -54,14 +54,14 @@ func (c *JoinCommand) Apply(server raft.Server) (interface{}, error) {
// Check peer number in the cluster
if ps.registry.Count() == ps.MaxClusterSize {
log.Debug("Reject join request from ", c.Name)
return []byte{0}, etcdErr.NewError(etcdErr.EcodeNoMorePeer, "", server.CommitIndex())
return []byte{0}, etcdErr.NewError(etcdErr.EcodeNoMorePeer, "", context.CommitIndex())
}
// Add to shared peer registry.
ps.registry.Register(c.Name, c.RaftURL, c.EtcdURL)
// Add peer in raft
err := server.AddPeer(c.Name, "")
err := context.Server().AddPeer(c.Name, "")
// Add peer stats
if c.Name != ps.RaftServer().Name() {

View File

@@ -440,15 +440,15 @@ func (s *PeerServer) raftEventLogger(event raft.Event) {
switch event.Type() {
case raft.StateChangeEventType:
fmt.Printf("[%s] State changed from '%v' to '%v'.\n", s.name, prevValue, value)
log.Infof("%s: state changed from '%v' to '%v'.", s.name, prevValue, value)
case raft.TermChangeEventType:
fmt.Printf("[%s] Term #%v started.\n", s.name, value)
log.Infof("%s: term #%v started.", s.name, value)
case raft.LeaderChangeEventType:
fmt.Printf("[%s] Leader changed from '%v' to '%v'.\n", s.name, prevValue, value)
log.Infof("%s: leader changed from '%v' to '%v'.", s.name, prevValue, value)
case raft.AddPeerEventType:
fmt.Printf("[%s] Peer added: '%v'\n", s.name, value)
log.Infof("%s: peer added: '%v'", s.name, value)
case raft.RemovePeerEventType:
fmt.Printf("[%s] Peer removed: '%v'\n", s.name, value)
log.Infof("%s: peer removed: '%v'", s.name, value)
}
}

View File

@@ -23,8 +23,8 @@ func (c *RemoveCommand) CommandName() string {
}
// Remove a server from the cluster
func (c *RemoveCommand) Apply(server raft.Server) (interface{}, error) {
ps, _ := server.Context().(*PeerServer)
func (c *RemoveCommand) Apply(context raft.Context) (interface{}, error) {
ps, _ := context.Server().Context().(*PeerServer)
// Remove node from the shared registry.
err := ps.registry.Unregister(c.Name)
@@ -38,21 +38,21 @@ func (c *RemoveCommand) Apply(server raft.Server) (interface{}, error) {
}
// Remove peer in raft
err = server.RemovePeer(c.Name)
err = context.Server().RemovePeer(c.Name)
if err != nil {
log.Debugf("Unable to remove peer: %s (%v)", c.Name, err)
return []byte{0}, err
}
if c.Name == server.Name() {
if c.Name == context.Server().Name() {
// the removed node is this node
// if the node is not replaying the previous logs
// and the node has sent out a join request in this
// start. It is sure that this node received a new remove
// command and need to be removed
if server.CommitIndex() > ps.joinIndex && ps.joinIndex != 0 {
log.Debugf("server [%s] is removed", server.Name())
if context.CommitIndex() > ps.joinIndex && ps.joinIndex != 0 {
log.Debugf("server [%s] is removed", context.Server().Name())
os.Exit(0)
} else {
// else ignore remove
@@ -61,7 +61,7 @@ func (c *RemoveCommand) Apply(server raft.Server) (interface{}, error) {
}
b := make([]byte, 8)
binary.PutUvarint(b, server.CommitIndex())
binary.PutUvarint(b, context.CommitIndex())
return b, err
}