From 3b9238439468393413499cd2a578c9846df44fa3 Mon Sep 17 00:00:00 2001 From: Anthony Romano Date: Mon, 22 Aug 2016 15:25:42 -0700 Subject: [PATCH] pkg/transport: bump wait time in TestReadWriteTimeoutDialer for write deadline Was able to get 2s wait times with 500 concurrent requests on a fast machine; a slower machine could possibly see similar delays with a single connection. Fixes #6220 --- pkg/transport/timeout_dialer_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/transport/timeout_dialer_test.go b/pkg/transport/timeout_dialer_test.go index 51e34d3d7..c082ca374 100644 --- a/pkg/transport/timeout_dialer_test.go +++ b/pkg/transport/timeout_dialer_test.go @@ -50,8 +50,9 @@ func TestReadWriteTimeoutDialer(t *testing.T) { select { case <-done: - // It waits 1s more to avoid delay in low-end system. - case <-time.After(d.wtimeoutd*10 + time.Second): + // Wait 5s more than timeout to avoid delay in low-end systems; + // the slack was 1s extra, but that wasn't enough for CI. + case <-time.After(d.wtimeoutd*10 + 5*time.Second): t.Fatal("wait timeout") }