From aaf4a70cd0e8f043a79b9fd307e2401965ddaea6 Mon Sep 17 00:00:00 2001
From: marco <marco.v.correia@gmail.com>
Date: Fri, 27 Oct 2017 08:48:22 +0100
Subject: [PATCH] etcdctl v3: e2e test for the --once option to the lease
 keep-alive command

Follow up #8775
---
 e2e/ctl_v3_lease_test.go               | 32 ++++++++++++++++++++++++++
 etcdctl/ctlv3/command/lease_command.go |  2 +-
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/e2e/ctl_v3_lease_test.go b/e2e/ctl_v3_lease_test.go
index 34571ac9f..4c11d0707 100644
--- a/e2e/ctl_v3_lease_test.go
+++ b/e2e/ctl_v3_lease_test.go
@@ -24,6 +24,7 @@ import (
 func TestCtlV3LeaseGrantTimeToLive(t *testing.T) { testCtl(t, leaseTestGrantTimeToLive) }
 func TestCtlV3LeaseGrantLeases(t *testing.T)     { testCtl(t, leaseTestGrantLeasesList) }
 func TestCtlV3LeaseKeepAlive(t *testing.T)       { testCtl(t, leaseTestKeepAlive) }
+func TestCtlV3LeaseKeepAliveOnce(t *testing.T)   { testCtl(t, leaseTestKeepAliveOnce) }
 func TestCtlV3LeaseRevoke(t *testing.T)          { testCtl(t, leaseTestRevoke) }
 
 func leaseTestGrantTimeToLive(cx ctlCtx) {
@@ -89,6 +90,23 @@ func leaseTestKeepAlive(cx ctlCtx) {
 	}
 }
 
+func leaseTestKeepAliveOnce(cx ctlCtx) {
+	// put with TTL 10 seconds and keep-alive once
+	leaseID, err := ctlV3LeaseGrant(cx, 10)
+	if err != nil {
+		cx.t.Fatalf("leaseTestKeepAlive: ctlV3LeaseGrant error (%v)", err)
+	}
+	if err := ctlV3Put(cx, "key", "val", leaseID); err != nil {
+		cx.t.Fatalf("leaseTestKeepAlive: ctlV3Put error (%v)", err)
+	}
+	if err := ctlV3LeaseKeepAliveOnce(cx, leaseID); err != nil {
+		cx.t.Fatalf("leaseTestKeepAlive: ctlV3LeaseKeepAliveOnce error (%v)", err)
+	}
+	if err := ctlV3Get(cx, []string{"key"}, kv{"key", "val"}); err != nil {
+		cx.t.Fatalf("leaseTestKeepAlive: ctlV3Get error (%v)", err)
+	}
+}
+
 func leaseTestRevoke(cx ctlCtx) {
 	// put with TTL 10 seconds and revoke
 	leaseID, err := ctlV3LeaseGrant(cx, 10)
@@ -143,6 +161,20 @@ func ctlV3LeaseKeepAlive(cx ctlCtx, leaseID string) error {
 	return proc.Stop()
 }
 
+func ctlV3LeaseKeepAliveOnce(cx ctlCtx, leaseID string) error {
+	cmdArgs := append(cx.PrefixArgs(), "lease", "keep-alive", "--once", leaseID)
+
+	proc, err := spawnCmd(cmdArgs)
+	if err != nil {
+		return err
+	}
+
+	if _, err = proc.Expect(fmt.Sprintf("lease %s keepalived with TTL(", leaseID)); err != nil {
+		return err
+	}
+	return proc.Stop()
+}
+
 func ctlV3LeaseRevoke(cx ctlCtx, leaseID string) error {
 	cmdArgs := append(cx.PrefixArgs(), "lease", "revoke", leaseID)
 	return spawnWithExpect(cmdArgs, fmt.Sprintf("lease %s revoked", leaseID))
diff --git a/etcdctl/ctlv3/command/lease_command.go b/etcdctl/ctlv3/command/lease_command.go
index 3b2452a9a..ecfe3a6fb 100644
--- a/etcdctl/ctlv3/command/lease_command.go
+++ b/etcdctl/ctlv3/command/lease_command.go
@@ -175,7 +175,7 @@ func leaseKeepAliveCommandFunc(cmd *cobra.Command, args []string) {
 	}
 
 	id := leaseFromArgs(args[0])
-	
+
 	if leaseKeepAliveOnce {
 		respc, kerr := mustClientFromCmd(cmd).KeepAliveOnce(context.TODO(), id)
 		if kerr != nil {