From 89a3a24d5a907d096059e5b408a2a2cc8978f38f Mon Sep 17 00:00:00 2001 From: Gyuho Lee Date: Sat, 9 May 2020 23:11:45 -0700 Subject: [PATCH] etcdserver: compute max request bytes humanized string once No need to compute the request size limit everytime in runtime Signed-off-by: Gyuho Lee --- etcdserver/server.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/etcdserver/server.go b/etcdserver/server.go index 33f7db068..ec9281944 100644 --- a/etcdserver/server.go +++ b/etcdserver/server.go @@ -104,7 +104,8 @@ const ( ) var ( - storeMemberAttributeRegexp = regexp.MustCompile(path.Join(membership.StoreMembersPrefix, "[[:xdigit:]]{1,16}", "attributes")) + recommendedMaxRequestBytesString = humanize.Bytes(uint64(recommendedMaxRequestBytes)) + storeMemberAttributeRegexp = regexp.MustCompile(path.Join(membership.StoreMembersPrefix, "[[:xdigit:]]{1,16}", "attributes")) ) func init() { @@ -298,7 +299,7 @@ func NewServer(cfg ServerConfig) (srv *EtcdServer, err error) { zap.Uint("max-request-bytes", cfg.MaxRequestBytes), zap.String("max-request-size", humanize.Bytes(uint64(cfg.MaxRequestBytes))), zap.Int("recommended-request-bytes", recommendedMaxRequestBytes), - zap.String("recommended-request-size", humanize.Bytes(uint64(recommendedMaxRequestBytes))), + zap.String("recommended-request-size", recommendedMaxRequestBytesString), ) }