From ab69c2adbd693b7e6da5bde4227ccfd700cace3c Mon Sep 17 00:00:00 2001 From: Jonathan Boulle Date: Mon, 3 Nov 2014 16:12:24 -0800 Subject: [PATCH] etcdhttp: use EcodePrevValueRequired when appropriate --- etcdserver/etcdhttp/client.go | 2 +- etcdserver/etcdhttp/client_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/etcdserver/etcdhttp/client.go b/etcdserver/etcdhttp/client.go index 8c324cf81..2e79fd934 100644 --- a/etcdserver/etcdhttp/client.go +++ b/etcdserver/etcdhttp/client.go @@ -342,7 +342,7 @@ func parseKeyRequest(r *http.Request, id uint64, clock clockwork.Clock) (etcdser pV := r.FormValue("prevValue") if _, ok := r.Form["prevValue"]; ok && pV == "" { return emptyReq, etcdErr.NewRequestError( - etcdErr.EcodeInvalidField, + etcdErr.EcodePrevValueRequired, `"prevValue" cannot be empty`, ) } diff --git a/etcdserver/etcdhttp/client_test.go b/etcdserver/etcdhttp/client_test.go index ab9af2e5e..832fe8a10 100644 --- a/etcdserver/etcdhttp/client_test.go +++ b/etcdserver/etcdhttp/client_test.go @@ -257,7 +257,7 @@ func TestBadParseRequest(t *testing.T) { // prevValue cannot be empty { mustNewForm(t, "foo", url.Values{"prevValue": []string{""}}), - etcdErr.EcodeInvalidField, + etcdErr.EcodePrevValueRequired, }, // wait is only valid with GET requests {