From ad86cb4d178baf8df208c5a3ce980e433fe2e924 Mon Sep 17 00:00:00 2001 From: Chun-Hung Tseng Date: Tue, 9 Apr 2024 15:51:04 +0200 Subject: [PATCH] documentation: improve triage_prs.md Signed-off-by: Chun-Hung Tseng --- Documentation/contributor-guide/triage_prs.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/contributor-guide/triage_prs.md b/Documentation/contributor-guide/triage_prs.md index c2b43ea76..3b9449510 100644 --- a/Documentation/contributor-guide/triage_prs.md +++ b/Documentation/contributor-guide/triage_prs.md @@ -5,23 +5,23 @@ Speed up PR management. The `etcd` PRs are listed at https://github.com/etcd-io/etcd/pulls -A PR can have various labels, milestone, reviewer etc. The detailed list of labels can be found at +A PR can have various labels, milestones, reviewers, etc. The detailed list of labels can be found at https://github.com/kubernetes/kubernetes/labels -Following are few example searches on PR for convenience: +Following are a few example searches on PR for convenience: * [Open PRS for milestone etcd-v3.6](https://github.com/etcd-io/etcd/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+milestone%3Aetcd-v3.6) * [PRs under investigation](https://github.com/etcd-io/etcd/labels/Investigating) ## Scope -These guidelines serves as a primary document for managing PRs in `etcd`. Everyone is welcome to help manage PRs but the work and responsibilities discussed in this document is created with `etcd` maintainers and active contributors in mind. +These guidelines serve as a primary document for managing PRs in `etcd`. Everyone is welcome to help manage PRs but the work and responsibilities discussed in this document are created with `etcd` maintainers and active contributors in mind. ## Handle inactive PRs -Poke PR owner if review comments are not addressed in 15 days. If PR owner does not reply in 90 days, update the PR with a new commit if possible. If not, inactive PR should be closed after 180 days. +Poke PR owner if review comments are not addressed in 15 days. If the PR owner does not reply in 90 days, update the PR with a new commit if possible. If not, inactive PR should be closed after 180 days. ## Poke reviewer if needed -Reviewers are responsive in a timely fashion, but considering everyone is busy, give them some time after requesting review if quick response is not provided. If response is not provided in 10 days, feel free to contact them via adding a comment in the PR or sending an email or message on the Slack. +Reviewers are responsive in a timely fashion, but considering everyone is busy, give them some time after requesting a review if a quick response is not provided. If the response is not provided in 10 days, feel free to contact them via adding a comment in the PR or sending an email or message on Slack. ## Verify important labels are in place