Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

wal : wal.Verify defer close the opened WAL files

Browse Source 
wal.Verify() : The opened WAL files are not closed in error cases. Fixed by adding a
defer.
This commit is contained in:
Vimal K 2019-09-04 23:38:14 +01:00
parent fb41ebea52
commit adbae79565
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
wal/wal.go
View File

@ -554,6 +554,11 @@ func Verify(lg *zap.Logger, walDir string, snap walpb.Snapshot) error {
if err != nil { if err != nil {
return err return err
} }
defer func() {
if closer != nil {
closer()
}
}()
// create a new decoder from the readers on the WAL files // create a new decoder from the readers on the WAL files
decoder := newDecoder(rs...) decoder := newDecoder(rs...)
@ -591,10 +596,6 @@ func Verify(lg *zap.Logger, walDir string, snap walpb.Snapshot) error {
} }
} }
if closer != nil {
closer()
}
// We do not have to read out all the WAL entries // We do not have to read out all the WAL entries
// as the decoder is opened in read mode. // as the decoder is opened in read mode.
if err != io.EOF && err != io.ErrUnexpectedEOF { if err != io.EOF && err != io.ErrUnexpectedEOF {