Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

etcd: rewrite SetFlagsFromEnv test to use custom flagset

Browse Source
This commit is contained in:
Brian Waldon 2014-09-24 16:27:00 -07:00
parent f7c353a703
commit b0617be7e3
1 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
main_test.go
View File

@ -5,38 +5,44 @@ import "flag"
import "testing"
func TestSetFlagsFromEnv(t *testing.T) {
fs := flag.NewFlagSet("testing", flag.ExitOnError)
fs.String("a", "", "")
fs.String("b", "", "")
fs.String("c", "", "")
fs.Parse([]string{})
os.Clearenv()
// flags should be settable using env vars
os.Setenv("ETCD_DATA_DIR", "/foo/bar")
os.Setenv("ETCD_A", "foo")
// and command-line flags
if err := flag.Set("peer-bind-addr", "1.2.3.4"); err != nil {
if err := fs.Set("b", "bar"); err != nil {
t.Fatal(err)
}
// command-line flags take precedence over env vars
os.Setenv("ETCD_ID", "woof")
if err := flag.Set("id", "quack"); err != nil {
os.Setenv("ETCD_C", "woof")
if err := fs.Set("c", "quack"); err != nil {
t.Fatal(err)
}
// first verify that flags are as expected before reading the env
for f, want := range map[string]string{
"data-dir": "",
"peer-bind-addr": "1.2.3.4",
"id": "quack",
"a": "",
"b": "bar",
"c": "quack",
} {
if got := flag.Lookup(f).Value.String(); got != want {
if got := fs.Lookup(f).Value.String(); got != want {
t.Fatalf("flag %q=%q, want %q", f, got, want)
}
}
// now read the env and verify flags were updated as expected
SetFlagsFromEnv(flag.CommandLine)
SetFlagsFromEnv(fs)
for f, want := range map[string]string{
"data-dir": "/foo/bar",
"peer-bind-addr": "1.2.3.4",
"id": "quack",
"a": "foo",
"b": "bar",
"c": "quack",
} {
if got := flag.Lookup(f).Value.String(); got != want {
if got := fs.Lookup(f).Value.String(); got != want {
t.Errorf("flag %q=%q, want %q", f, got, want)
}
}